Remove Repository.getFilesChanged to fix Actions paths and paths-ignore filter
#23920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolfogre
approved these changes
Apr 6, 2023
GiteaBot
added
the
lgtm/need 1
wolfogre
changed the title
paths and paths …paths and paths filter
lunny
approved these changes
Apr 6, 2023
GiteaBot
added
lgtm/done
lunny
added
reviewed/wait-merge
delvh
approved these changes
Apr 6, 2023
delvh
changed the title
paths and paths filterRepository.getFilesChanged to fix Actions paths and paths filter
ChristopherHX
changed the title
Repository.getFilesChanged to fix Actions paths and paths filterRepository.getFilesChanged to fix Actions paths and paths-ignore filter
lunny
removed
the
reviewed/wait-merge
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Apr 7, 2023
…-ignore` filter (go-gitea#23920) Remove the misbehaving function and call Repository.GetFilesChangedBetween instead. Fixes go-gitea#23919 --- ~~_TODO_ test this~~ `Repository.getFilesChanged` seems to be only used by Gitea Actions, but a similar function already exists **Update** I tested this change and the issue is gone.
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Apr 7, 2023
* upstream/main: Clean template/helper.go (go-gitea#23922) Remove `Repository.getFilesChanged` to fix Actions `paths` and `paths-ignore` filter (go-gitea#23920) Hardcode path to docker images (go-gitea#23955) Title can be empty when creating tag only (go-gitea#23917) Actions: Use default branch as ref when a branch/tag delete occurs (go-gitea#23910) Refactor authors dropdown (send get request from frontend to avoid long wait time) (go-gitea#23890) [skip ci] Updated translations via Crowdin Merge `push to create`, `open PR from push`, and `push options` docs articles into one (go-gitea#23744) Delete deleted release attachments immediately from storage (go-gitea#23913) More specific and unique feed name for NuGet install command template. (go-gitea#23889) Treat PRs with agit flow as fork PRs when triggering actions. (go-gitea#23884) Use graceful editorconfig loader to reduce errors when loading malformed editorconfigs (go-gitea#21257) Remove -v from vulncheck (go-gitea#23953) Improve permission check of packages (go-gitea#23879) Adjust some documentations titles (go-gitea#23941)
lunny
pushed a commit
that referenced
this pull request
Apr 8, 2023
…-ignore` filter (#23920) (#23969) Backport #23920 by @ChristopherHX Remove the misbehaving function and call Repository.GetFilesChangedBetween instead. Fixes #23919 --- ~~_TODO_ test this~~ `Repository.getFilesChanged` seems to be only used by Gitea Actions, but a similar function already exists **Update** I tested this change and the issue is gone. Co-authored-by: ChristopherHX <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the misbehaving function and call Repository.GetFilesChangedBetween instead.
Fixes #23919
TODO test thisRepository.getFilesChangedseems to be only used by Gitea Actions, but a similar function already existsUpdate I tested this change and the issue is gone.