Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat PRs with agit flow as fork PRs when triggering actions. (#23884) #23967

Merged
merged 3 commits into from
Apr 7, 2023
Merged

Treat PRs with agit flow as fork PRs when triggering actions. (#23884) #23967

merged 3 commits into from
Apr 7, 2023

Conversation

wolfogre
Copy link
Member

@wolfogre wolfogre commented Apr 7, 2023

Backport #23884.

There is no fork concept in agit flow, anyone with read permission can push refs/for/<target-branch>/<topic-branch> to the repo. So we should treat it as a fork pull request because it may be from an untrusted user.

There is no fork concept in agit flow, anyone with read permission can
push `refs/for/<target-branch>/<topic-branch>` to the repo. So we should
treat it as a fork pull request because it may be from an untrusted
user.
@wolfogre wolfogre added type/enhancement An improvement of existing functionality topic/gitea-actions related to the actions of Gitea labels Apr 7, 2023
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 7, 2023
@lunny lunny added this to the 1.19.1 milestone Apr 7, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 7, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 7, 2023
@jolheiser jolheiser enabled auto-merge (squash) April 7, 2023 20:42
@jolheiser
Copy link
Member

🎺 🤖

@jolheiser jolheiser merged commit 0487e39 into go-gitea:release/v1.19 Apr 7, 2023
@jolheiser jolheiser removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 7, 2023
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Aug 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/gitea-actions related to the actions of Gitea type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants