Unify nightly naming across binaries and docker images #24116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
techknowlogick
added
type/enhancement
wxiaoguang
reviewed
Apr 14, 2023
GiteaBot
added
the
lgtm/need 2
Well yes ... it just depend how complex our docker manifest build step is going to get |
|
I would propose to drop the
I do not think it make senses to continue using the And I think almost all edge version users have the ability to fix their deployed image names. Even if they don't change, there is no hurt, until they find that they need the nightly, then change. |
silverwind
approved these changes
Apr 22, 2023
GiteaBot
added
lgtm/need 1
pull-request-size
bot
added
the
size/S
lunny
approved these changes
Apr 23, 2023
GiteaBot
added
lgtm/done
wxiaoguang
approved these changes
Apr 24, 2023
jolheiser
added
the
reviewed/wait-merge
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Apr 24, 2023
Proposal found here: go-gitea#23654 TODO: make non-breaking (can we publish docker image using dev and nightly prefix? at same time). if anyone has advice please comment :) If this PR is merged, then I can add redirects to the downloads site.
GiteaBot
added
backport/done
silverwind
pushed a commit
that referenced
this pull request
Apr 24, 2023
Backport #24116 by @techknowlogick Proposal found here: #23654 TODO: make non-breaking (can we publish docker image using dev and nightly prefix? at same time). if anyone has advice please comment :) If this PR is merged, then I can add redirects to the downloads site. Co-authored-by: techknowlogick <[email protected]>
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Apr 25, 2023
* giteaofficial/main: default show closed actions list if all actions was closed (go-gitea#24234) [skip ci] Updated translations via Crowdin update nightly drone docker tag (go-gitea#24311) Remove org users who belong to no teams (go-gitea#24247) Fix typo in API route (go-gitea#24310) Add --font-weight-bold and set previous bold to 601 (go-gitea#24307) Mark `/templates/swagger/v1_json.tmpl` as generated file (go-gitea#24306) Improve External Wiki in Repo Header (go-gitea#24304) Unify nightly naming across binaries and docker images (go-gitea#24116) Wrap too long push mirror addresses (go-gitea#21120)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal found here: #23654
TODO: make non-breaking (can we publish docker image using dev and nightly prefix? at same time). if anyone has advice please comment :)
If this PR is merged, then I can add redirects to the downloads site.