Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move secrets and runners settings to actions settings #24200

Merged
merged 55 commits into from
Apr 28, 2023
Merged
Show file tree
Hide file tree
Changes from 47 commits
Commits
Show all changes
55 commits
Select commit Hold shift + click to select a range
1b1e52c
move secrets to actions(repo)
HesterG Apr 19, 2023
f5737f7
update secretes and runners for org
HesterG Apr 19, 2023
118f1e1
modify admin
HesterG Apr 19, 2023
22f9c76
modify search
HesterG Apr 19, 2023
d20aad6
modify for user level
HesterG Apr 19, 2023
aa38122
revert comment
HesterG Apr 19, 2023
02cc857
hide user level action if not enabled
HesterG Apr 19, 2023
586b380
secrets management locale
HesterG Apr 19, 2023
17e77c6
refactor names
HesterG Apr 19, 2023
f3e2fbe
remove unused tmpl and comments
HesterG Apr 19, 2023
8a3af8b
fix some titles and use PageIsOrgSettings
HesterG Apr 19, 2023
177cfa4
fix lint and use string
HesterG Apr 19, 2023
40596aa
try adjust error position and pass ResetRegistrationTokenLink
HesterG Apr 19, 2023
e7d41b3
use some format of variable and delete runners/base
HesterG Apr 19, 2023
aa6aefb
change classname and css
HesterG Apr 19, 2023
7414385
rename
HesterG Apr 19, 2023
4674fc5
change ctx data passed to shared templates and add redirext
HesterG Apr 20, 2023
6d5cdd4
fix backend check
HesterG Apr 20, 2023
99781f2
change alert position
HesterG Apr 20, 2023
88306c0
rename function
HesterG Apr 20, 2023
c119639
use capital and move redirect to function
HesterG Apr 20, 2023
4903d7c
rename admin/settings_actions.go and improve org/setting_actions
HesterG Apr 20, 2023
d4acdc8
put settings in one folder
HesterG Apr 20, 2023
e849999
rename
HesterG Apr 20, 2023
311e953
fix lint
HesterG Apr 21, 2023
0e79e6e
make repo settings runners/secrets submenus
HesterG Apr 23, 2023
42f26c5
fix path and lint
HesterG Apr 24, 2023
867b373
make runner/secrets submenu on user and admin
HesterG Apr 24, 2023
0a68dda
change actions classname
HesterG Apr 24, 2023
d63330e
fix path
HesterG Apr 24, 2023
2019081
remove unnecessary change
HesterG Apr 24, 2023
b09c289
rename redirect function
HesterG Apr 24, 2023
a75ae88
rename file
HesterG Apr 24, 2023
244e568
separate routers for runners and secrets
HesterG Apr 25, 2023
a176331
adjust margin-left for vertical sub menu
HesterG Apr 25, 2023
f0788c6
use helper.css
HesterG Apr 25, 2023
fbd07c1
rename files
HesterG Apr 25, 2023
e0b4ec3
remove some changes
HesterG Apr 25, 2023
fbeb9ab
use variables for colors
HesterG Apr 25, 2023
38c8818
use text-indent instead of margin
HesterG Apr 25, 2023
bf43048
use the same rule
HesterG Apr 25, 2023
3d1def2
add custom class
HesterG Apr 27, 2023
def9495
Merge branch 'main' into move-secrets-to-actions
HesterG Apr 27, 2023
3d57d12
Merge branch 'main' into move-secrets-to-actions
HesterG Apr 27, 2023
fa112e5
use common handlers
HesterG Apr 27, 2023
ad374cd
add TODO
HesterG Apr 27, 2023
aca8a06
Merge branch 'main' into move-secrets-to-actions
HesterG Apr 27, 2023
42905d3
change conditions
HesterG Apr 27, 2023
bbb2c33
Merge branch 'main' into move-secrets-to-actions
HesterG Apr 27, 2023
4cd0166
simplify ctx data
wxiaoguang Apr 27, 2023
961d7bc
remove unnecessary PageIsAdmin
wxiaoguang Apr 27, 2023
ddd0661
remove g-settings-submenu
wxiaoguang Apr 27, 2023
d0d2e46
sub menu of vertical menu
wxiaoguang Apr 27, 2023
5d0644c
Merge branch 'main' into move-secrets-to-actions
GiteaBot Apr 27, 2023
1cf73f1
Merge branch 'main' into move-secrets-to-actions
GiteaBot Apr 27, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions options/locale/locale_en-US.ini
Original file line number Diff line number Diff line change
Expand Up @@ -3356,6 +3356,7 @@ deletion = Remove secret
deletion.description = Removing a secret is permanent and cannot be undone. Continue?
deletion.success = The secret has been removed.
deletion.failed = Failed to remove secret.
management = Secrets Management

[actions]
actions = Actions
Expand Down
69 changes: 2 additions & 67 deletions routers/web/admin/runners.go
Original file line number Diff line number Diff line change
Expand Up @@ -4,75 +4,10 @@
package admin

import (
"net/url"

actions_model "code.gitea.io/gitea/models/actions"
"code.gitea.io/gitea/models/db"
"code.gitea.io/gitea/modules/base"
"code.gitea.io/gitea/modules/context"
"code.gitea.io/gitea/modules/setting"
actions_shared "code.gitea.io/gitea/routers/web/shared/actions"
)

const (
tplRunners base.TplName = "admin/runners/base"
tplRunnerEdit base.TplName = "admin/runners/edit"
)

// Runners show all the runners
func Runners(ctx *context.Context) {
ctx.Data["Title"] = ctx.Tr("actions.runners")
ctx.Data["PageIsAdmin"] = true
ctx.Data["PageIsAdminRunners"] = true

page := ctx.FormInt("page")
if page <= 1 {
page = 1
}

opts := actions_model.FindRunnerOptions{
ListOptions: db.ListOptions{
Page: page,
PageSize: 100,
},
Sort: ctx.Req.URL.Query().Get("sort"),
Filter: ctx.Req.URL.Query().Get("q"),
}

actions_shared.RunnersList(ctx, tplRunners, opts)
}

// EditRunner show editing runner page
func EditRunner(ctx *context.Context) {
ctx.Data["Title"] = ctx.Tr("actions.runners.edit_runner")
ctx.Data["PageIsAdmin"] = true
ctx.Data["PageIsAdminRunners"] = true

page := ctx.FormInt("page")
if page <= 1 {
page = 1
}

actions_shared.RunnerDetails(ctx, tplRunnerEdit, page, ctx.ParamsInt64(":runnerid"), 0, 0)
}

// EditRunnerPost response for editing runner
func EditRunnerPost(ctx *context.Context) {
ctx.Data["Title"] = ctx.Tr("actions.runners.edit")
ctx.Data["PageIsAdmin"] = true
ctx.Data["PageIsAdminRunners"] = true
actions_shared.RunnerDetailsEditPost(ctx, ctx.ParamsInt64(":runnerid"), 0, 0,
setting.AppSubURL+"/admin/runners/"+url.PathEscape(ctx.Params(":runnerid")))
}

// DeleteRunnerPost response for deleting a runner
func DeleteRunnerPost(ctx *context.Context) {
actions_shared.RunnerDeletePost(ctx, ctx.ParamsInt64(":runnerid"),
setting.AppSubURL+"/admin/runners/",
setting.AppSubURL+"/admin/runners/"+url.PathEscape(ctx.Params(":runnerid")),
)
}

func ResetRunnerRegistrationToken(ctx *context.Context) {
actions_shared.RunnerResetRegistrationToken(ctx, 0, 0, setting.AppSubURL+"/admin/runners/")
func RedirectToDefaultSetting(ctx *context.Context) {
ctx.Redirect(setting.AppSubURL + "/admin/actions/runners")
}
78 changes: 0 additions & 78 deletions routers/web/org/org_runners.go

This file was deleted.

4 changes: 0 additions & 4 deletions routers/web/org/setting.go
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,6 @@ const (
tplSettingsHooks base.TplName = "org/settings/hooks"
// tplSettingsLabels template path for render labels settings
tplSettingsLabels base.TplName = "org/settings/labels"
// tplSettingsRunners template path for render runners settings
tplSettingsRunners base.TplName = "org/settings/runners"
// tplSettingsRunnersEdit template path for render runners edit settings
tplSettingsRunnersEdit base.TplName = "org/settings/runners_edit"
)

// Settings render the main settings page
Expand Down
12 changes: 12 additions & 0 deletions routers/web/org/setting/runners.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
// Copyright 2022 The Gitea Authors. All rights reserved.
// SPDX-License-Identifier: MIT

package setting

import (
"code.gitea.io/gitea/modules/context"
)

func RedirectToDefaultSetting(ctx *context.Context) {
ctx.Redirect(ctx.Org.OrgLink + "/settings/actions/runners")
}
50 changes: 0 additions & 50 deletions routers/web/org/setting_secrets.go

This file was deleted.

76 changes: 0 additions & 76 deletions routers/web/repo/runners.go

This file was deleted.

Loading