Fix layouts of admin table / adapt repo / email test #24370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/S
wxiaoguang
force-pushed
the
fix-admin-table
branch
from
04a979c
to
6f00d92
Compare
lunny
approved these changes
Apr 27, 2023
GiteaBot
added
lgtm/need 1
|
Can we also add |
pull-request-size
bot
added
size/M
pull-request-size
bot
added
size/L
Done in d090db6 Ready for review (again) |
HesterG
approved these changes
Apr 27, 2023
GiteaBot
added
lgtm/done
wxiaoguang
changed the title
wxiaoguang
changed the title
silverwind
reviewed
Apr 27, 2023
lunny
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Apr 28, 2023
* giteaofficial/main: (26 commits) Refactor docs (go-gitea#23752) Fix layouts of admin table / adapt repo / email test (go-gitea#24370) Move secrets and runners settings to actions settings (go-gitea#24200) Gitea Actions add `base_ref`, `head_ref`, `api_url`, `ref_type` fields (go-gitea#24356) Fix auth check bug (go-gitea#24382) Display 'Unknown' when runner.version is empty (go-gitea#24378) Fix incorrect last online time in runner_edit.tmpl (go-gitea#24376) Refactor "route" related code, fix Safari cookie bug (go-gitea#24330) Add custom helm repo name generated from url (go-gitea#24363) Add API for gitignore templates (go-gitea#22783) Add eslint-plugin-regexp (go-gitea#24361) Support uploading file to empty repo by API (go-gitea#24357) [skip ci] Updated translations via Crowdin Require repo scope for PATs for private repos and basic authentication (go-gitea#24362) Alert error message if open dependencies are included in the issues that try to batch close (go-gitea#24329) Fix 404 error when leaving the last private org team (go-gitea#24322) Modify width of ui container, fine tune css for settings pages and org header (go-gitea#24315) Add .livemd as a markdown extension (go-gitea#22730) Display when a repo was archived (go-gitea#22664) Fix wrong error info in RepoRefForAPI (go-gitea#24344) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #24315 (review)
And fix the incorrect layout for "dasbboard", the "form" shouldn't follow
<h4 class="ui top attached header">, so move it to inner.Diff with ignoring spaces: https://github.com/go-gitea/gitea/pull/24370/files?diff=unified&w=1
A known bug: the adapt/delete button doesn't work due to a historical messy logic, will fix it in next PR (#24374)