Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localize N/A #24427

Closed
wants to merge 3 commits into from
Closed

Localize N/A #24427

wants to merge 3 commits into from

Conversation

yardenshoham
Copy link
Member

@yardenshoham yardenshoham commented Apr 29, 2023

I saw this string hardcoded in a few places

I saw this string hardcoded in a few places. I'm not sure how to call this key, hopefully `short_not_available` is good enough.

Signed-off-by: Yarden Shoham <[email protected]>
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 29, 2023
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 29, 2023
Co-authored-by: wxiaoguang <[email protected]>
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 29, 2023
@silverwind
Copy link
Member

Hmm, I do wonder what happens when translators introduce longer strings for it. Can the places where it's used realistically render larger content?

@yardenshoham
Copy link
Member Author

Yes
image

@silverwind
Copy link
Member

silverwind commented Apr 29, 2023

Hmm, I doubt we will get many sensical translations. N/A is a english-only abbreviation and I wouldn't know how to translate it into german for example, as the language has no equivalent abbreviation.

How about just rendering a neutral -? That will work fine as well in these tables and needs no translation. In your screenshot, that is already used in the schedule table so it's consistent as well.

@wxiaoguang
Copy link
Contributor

I also agree to keep the "N/A", it is a well-known word, especially in technical field.

Either is fine.

@wxiaoguang
Copy link
Contributor

Actually, I think some N/A strings could be replaced by some more accurate word.

The last time I used "N/A" because there is no result. But I really do not want to put another "No record" translation there ....

(well, I admit that I am somewhat lazy on some problems ....)

While from another perspective, maybe N/A is not that bad, I am pretty neutral.

@silverwind
Copy link
Member

silverwind commented Apr 29, 2023

Let's just use -. It's already in use in the same exact lists, needs no translation and is perfectly short. It's a great fit.

@yardenshoham why close? Not interested in continuing? Should I raise another?

@silverwind
Copy link
Member

Let's just use -. It's already in use in the same exact lists, needs no translation and is perfectly short. It's a great fit.

@yardenshoham why close? Not interested in continuing? Should I raise another?

#24474

silverwind added a commit that referenced this pull request May 2, 2023
Followup to #24427.

Reasoning is that `N/A` is specific to english while `-` is
language-neutral and does not need translation.

Before:
<img width="891" alt="Screenshot 2023-05-01 at 20 58 20"
src="https://user-images.githubusercontent.com/115237/235511592-8a36d0f2-34ff-4dbe-b642-67c0ade644fe.png">

After:
<img width="901" alt="Screenshot 2023-05-01 at 20 59 59"
src="https://user-images.githubusercontent.com/115237/235511594-d49f6d09-92e8-4e99-be7b-2a37f5d24129.png">
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jul 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/need 1 This PR needs approval from one additional maintainer to be merged. modifies/translation size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants