Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up polluted styles and remove dead CSS code #24497

Merged
merged 2 commits into from
May 3, 2023

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented May 3, 2023

Follow #24393

The funny history:

  • At the beginning, .ui.message was polluted by text-align: center
  • Then people do <div class="ui ... message text left">
  • But .ui.left is polluted by float: left
  • Then people do #xxx .ui.message { width: 100% !important;}

The code just becomes more and more hacky.

After removing the pollution, everything becomes clear and straight.

And, this PR also does:

  1. Remove the package.css, its styles could be provided by top aligned
  2. Remove #avatar-arrow, dead code

Screenshot:

image

image

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 3, 2023
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 3, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 3, 2023
@wxiaoguang wxiaoguang added this to the 1.20.0 milestone May 3, 2023
@silverwind
Copy link
Member

silverwind commented May 3, 2023

Remove #avatar-arrow, dead code

Where is it handled now?

@wxiaoguang
Copy link
Contributor Author

Remove #avatar-arrow, dead code

Where is it's replacement?

Just dead code IMO, no avatar-arrow in code base

@silverwind
Copy link
Member

Remove #avatar-arrow, dead code

Where is it's replacement?

Just dead code IMO, no avatar-arrow in code base

Ah I think that was the triangle besides issue comments, now handled by .comment-header::before, .comment-header::after

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 3, 2023
@silverwind silverwind added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 3, 2023
@silverwind silverwind enabled auto-merge (squash) May 3, 2023 17:31
@silverwind silverwind merged commit 48e3e38 into go-gitea:main May 3, 2023
@wxiaoguang wxiaoguang deleted the fix-ui-more branch May 3, 2023 18:33
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 3, 2023
zjjhot added a commit to zjjhot/gitea that referenced this pull request May 4, 2023
* upstream/main: (65 commits)
  Changelog for 1.19.3 (go-gitea#24495) (go-gitea#24506)
  Use Actions for DB & E2E tests (go-gitea#24494)
  Fix intermittent CI failure in EmptyQueue (go-gitea#23753)
  Prevent a user with a different email from accepting the team invite (go-gitea#24491)
  Fix incorrect webhook time and use relative-time to display it (go-gitea#24477)
  Make Issue/PR/projects more compact, misc CSS tweaks (go-gitea#24459)
  Implement Cargo HTTP index (go-gitea#24452)
  Clean up polluted styles and remove dead CSS code (go-gitea#24497)
  Improve pull request merge box when pull request merged and branch deleted. (go-gitea#24397)
  Fix EasyMDE toolbar (go-gitea#24489)
  Enhance stylelint rule config, remove dead CSS (go-gitea#24472)
  Fix api error message if fork exists (go-gitea#24487)
  Add ntlm authentication support for mail (go-gitea#23811)
  Fix test delivery button in repo webhook settings page (go-gitea#24478)
  Add Debian package registry (go-gitea#24426)
  Enable whitespace rendering on selection in Monaco (go-gitea#24444)
  Replace `N/A` with `-` everywhere (go-gitea#24474)
  Fix invite display (go-gitea#24447)
  [skip ci] Updated translations via Crowdin
  replace PR docker dry run in drone with Actions (go-gitea#24475)
  ...

# Conflicts:
#	templates/base/footer_content.tmpl
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Aug 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants