Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent a user with a different email from accepting the team invite (#24491) #24509

Closed

Conversation

GiteaBot
Copy link
Contributor

@GiteaBot GiteaBot commented May 4, 2023

Backport #24491 by @jackHay22

Changes

  • Fixes the case where a logged in user can accept an email invitation even if their email address does not match the address in the invitation

…o-gitea#24491)

## Changes
- Fixes the case where a logged in user can accept an email invitation
even if their email address does not match the address in the invitation
@GiteaBot GiteaBot added this to the 1.19.3 milestone May 4, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 4, 2023
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 4, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 4, 2023
@techknowlogick techknowlogick added the type/enhancement An improvement of existing functionality label May 4, 2023
@lunny lunny modified the milestones: 1.19.3, 1.19.4 May 4, 2023
Copy link
Member

@KN4CK3R KN4CK3R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking until we are sure we want this change.
Reference #24491 (comment)

@GiteaBot GiteaBot added lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 4, 2023
@lunny lunny removed this from the 1.19.4 milestone May 5, 2023
@lunny lunny closed this May 5, 2023
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Aug 3, 2023
@techknowlogick techknowlogick deleted the backport-24491-v1.19 branch September 9, 2023 05:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants