Do not send "registration success email" for external auth sources #24632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/S
lunny
approved these changes
May 10, 2023
GiteaBot
added
lgtm/need 1
silverwind
approved these changes
May 10, 2023
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
May 11, 2023
* upstream/main: Fix typo in act-runner file (go-gitea#24652) RSS icon fixes (go-gitea#24476) Notification list enhancements, fix striped tables on dark theme (go-gitea#24639) Improve "goto issue by number" button (go-gitea#24577) Increase default LFS auth timeout from 20m to 24h (go-gitea#24628) Fix typo in the swift package documentation (go-gitea#24637) Fix broken links in documents (go-gitea#24630) Improve updating Actions tasks (go-gitea#24600) Modify luminance calculation and extract related functions into single files (go-gitea#24586) Do not send "registration success email" for external auth sources (go-gitea#24632) Fix typo in Actions demo file (go-gitea#24631) Review fixes and enhancements (go-gitea#24526) Remove fluid on compare diff page (go-gitea#24627) Make the actions control button look like an actual button (go-gitea#24611) Add a tooltip to the job rerun button (go-gitea#24617) Improve reverse-proxy document and fix nginx config bug (go-gitea#24616)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-author: @pboguslawski
"registration success email" is only used for notifying a user that "you have a new account now" when the account is created by admin manually.
When a user uses external auth source, they already knows that they has the account, so do not send such email.