Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issues list page multiple selection update milestones #24660

Merged
merged 1 commit into from
May 11, 2023
Merged

Fix issues list page multiple selection update milestones #24660

merged 1 commit into from
May 11, 2023

Conversation

lunny
Copy link
Member

@lunny lunny commented May 11, 2023

Fix #24651

@lunny lunny added type/bug outdated/backport/v1.19 This PR should be backported to Gitea 1.19 labels May 11, 2023
@lunny lunny added this to the 1.20.0 milestone May 11, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 11, 2023
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 11, 2023
wxiaoguang
wxiaoguang approved these changes May 11, 2023
View reviewed changes
Copy link
Contributor

@wxiaoguang wxiaoguang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea whether it is right or wrong.

Since it's a bug fix and it should have been tested, so approve.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 11, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 11, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 11, 2023
@lunny lunny merged commit 365bb77 into go-gitea:main May 11, 2023
@lunny lunny deleted the lunny/fix_issue_milestones branch May 11, 2023 13:19
@GiteaBot GiteaBot mentioned this pull request May 11, 2023
Merged
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 11, 2023
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request May 11, 2023
@lunny @GiteaBot
Fix issues list page multiple selection update milestones (go-gitea#2…
6c337da 
…4660)

Fix go-gitea#24651
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label May 11, 2023
zjjhot added a commit to zjjhot/gitea that referenced this pull request May 12, 2023
@zjjhot
Merge remote-tracking branch 'upstream/main'
39754d7 
* upstream/main:
  GitHub Actions cleanups (go-gitea#24620)
  Fix issues list page multiple selection update milestones (go-gitea#24660)
  Make repo migration cancelable and fix various bugs (go-gitea#24605)
  Improve queue & process & stacktrace (go-gitea#24636)
  Fix missing badges in org settings page (go-gitea#24654)
  Only show one tippy at a time (go-gitea#24648)
  Reenable creating default webhooks. (go-gitea#24626)
  Kd/fix redis unit test (go-gitea#24650)
silverwind pushed a commit that referenced this pull request May 12, 2023
@GiteaBot @lunny
Fix issues list page multiple selection update milestones (#24660) (#…
8f72201 
…24663)

Backport #24660 by @lunny

Fix #24651

Co-authored-by: Lunny Xiao <[email protected]>
Codeberg-org pushed a commit to Codeberg-org/gitea that referenced this pull request Jun 3, 2023
@GiteaBot @earl-warren
Fix issues list page multiple selection update milestones (go-gitea#2…
55d0620 
…4660) (go-gitea#24663)

Backport go-gitea#24660 by @lunny

Fix go-gitea#24651

Co-authored-by: Lunny Xiao <[email protected]>
(cherry picked from commit 8f72201)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Aug 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@silverwind silverwind silverwind approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. outdated/backport/v1.19 This PR should be backported to Gitea 1.19 size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/bug
Projects
None yet
Milestone
1.20.0
Development

Successfully merging this pull request may close these issues.

Milestones are disabled in bulk edit mode
4 participants
@lunny @silverwind @wxiaoguang @GiteaBot