Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return 404 in the API if the requested webhooks were not found #24823

Merged
merged 6 commits into from
May 21, 2023
Merged

Return 404 in the API if the requested webhooks were not found #24823

merged 6 commits into from
May 21, 2023

Conversation

sonjek
Copy link
Contributor

@sonjek sonjek commented May 20, 2023

Should resolve first point of the issue #24574

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 20, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 20, 2023
@pull-request-size pull-request-size bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 20, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 20, 2023
@sonjek
Copy link
Contributor Author

sonjek commented May 20, 2023

@delvh I added a test. How can I test that it works?

@delvh delvh changed the title API return 404 if requested webhooks is not found Return 404 in the API if the requested webhooks were not found May 20, 2023
@delvh
Copy link
Member

delvh commented May 20, 2023

We wait for the CI icons to turn green (except for giteabot/lgtm, that will only turn green with the second approval).
That's the easiest approach.

@delvh
Copy link
Member

delvh commented May 20, 2023

Otherwise, you can also try a local make test-backend or something like that.

@pull-request-size pull-request-size bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 20, 2023
@delvh delvh added modifies/api This PR adds API routes or modifies them type/bug labels May 20, 2023
techknowlogick
techknowlogick approved these changes May 21, 2023
View reviewed changes
Copy link
Member

@techknowlogick techknowlogick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙏

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 21, 2023
@techknowlogick techknowlogick added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 21, 2023
@lunny lunny merged commit 1dfaf83 into go-gitea:main May 21, 2023
@GiteaBot GiteaBot added this to the 1.20.0 milestone May 21, 2023
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 21, 2023
@xanderxfz
Copy link

Hi, @lunny @delvh, can we backport this bugfix to 1.19.X?

@lunny lunny added the outdated/backport/v1.19 This PR should be backported to Gitea 1.19 label May 21, 2023
@lunny
Copy link
Member

lunny commented May 21, 2023

@GiteaBot Please send backport to v1.19

@yardenshoham
Copy link
Member

It'll do so on the next merge to main

@GiteaBot GiteaBot mentioned this pull request May 21, 2023
Merged
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request May 21, 2023
@sonjek @GiteaBot
Return 404 in the API if the requested webhooks were not found (go-…
5d2e031 
…gitea#24823)

Should resolve first point of the issue
go-gitea#24574
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label May 21, 2023
techknowlogick pushed a commit that referenced this pull request May 21, 2023
@GiteaBot @sonjek
Return 404 in the API if the requested webhooks were not found (#24823
f29c52a 
) (#24830)

Backport #24823 by @sonjek

Should resolve first point of the issue
#24574

Co-authored-by: Yevhen Pavlov <[email protected]>
silverwind added a commit to bl00mber/gitea that referenced this pull request May 21, 2023
@silverwind
Merge branch 'main' into milestone-labels
e336a1e 
* main: (90 commits)
  Refactor rename user and rename organization (go-gitea#24052)
  Use `CommentList` instead of `[]*Comment` (go-gitea#24828)
  Fix topics deleted via API not being deleted in org page (go-gitea#24825)
  Return `404` in the API if the requested webhooks were not found (go-gitea#24823)
  Decouple the different contexts from each other (go-gitea#24786)
  [skip ci] Updated translations via Crowdin
  Add RTL rendering support to Markdown (go-gitea#24816)
  [skip ci] Updated translations via Crowdin
  Update JS dependencies (go-gitea#24815)
  Fix duplicate tooltip hiding (go-gitea#24814)
  Mute repo names in dashboard repo list (go-gitea#24811)
  Rework label colors (go-gitea#24790)
  Fix max width and margin of comment box on conversation page (go-gitea#24809)
  Allow all URL schemes in Markdown links by default (go-gitea#24805)
  Some refactors for issues stats (go-gitea#24793)
  Implement actions artifacts (go-gitea#22738)
  Fix Actions being enabled accidentally (go-gitea#24802)
  Change `add_on` in `keys_ssh.tmpl` (go-gitea#24803)
  replace `drone exec` to `act_runner exec` in test README.md (go-gitea#24791)
  Fix OAuth loading state (go-gitea#24788)
  ...
zjjhot added a commit to zjjhot/gitea that referenced this pull request May 22, 2023
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
6791aa3 
* giteaofficial/main: (27 commits)
  Fix regression: access log template, gitea manager cli command (go-gitea#24838)
  Merge message template support for rebase without merge commit (go-gitea#22669)
  [skip ci] Updated licenses and gitignores
  Support wildcard in email domain allow/block list (go-gitea#24831)
  Change `--font-weight-bold` to `--font-weight-semibold` and 600 value, introduce new font weight variables (go-gitea#24827)
  Rewrite logger system (go-gitea#24726)
  Support Copy Link for video attachments (go-gitea#24833)
  Fix video width overflow in markdown, and other changes to match img (go-gitea#24834)
  Improve accessibility when (re-)viewing files (go-gitea#24817)
  Refactor rename user and rename organization (go-gitea#24052)
  Use `CommentList` instead of `[]*Comment` (go-gitea#24828)
  Fix topics deleted via API not being deleted in org page (go-gitea#24825)
  Return `404` in the API if the requested webhooks were not found (go-gitea#24823)
  Decouple the different contexts from each other (go-gitea#24786)
  [skip ci] Updated translations via Crowdin
  Add RTL rendering support to Markdown (go-gitea#24816)
  [skip ci] Updated translations via Crowdin
  Update JS dependencies (go-gitea#24815)
  Fix duplicate tooltip hiding (go-gitea#24814)
  Mute repo names in dashboard repo list (go-gitea#24811)
  ...
Codeberg-org pushed a commit to Codeberg-org/gitea that referenced this pull request Jun 3, 2023
@GiteaBot @earl-warren
Return 404 in the API if the requested webhooks were not found (go-…
16bccee 
…gitea#24823) (go-gitea#24830)

Backport go-gitea#24823 by @sonjek

Should resolve first point of the issue
go-gitea#24574

Co-authored-by: Yevhen Pavlov <[email protected]>
(cherry picked from commit f29c52a)
@Zettat123 Zettat123 mentioned this pull request Jun 28, 2023
Closed
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Aug 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@delvh delvh delvh approved these changes

@techknowlogick techknowlogick techknowlogick approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them outdated/backport/v1.19 This PR should be backported to Gitea 1.19 size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/bug
Projects
None yet
Milestone
1.20.0
Development

Successfully merging this pull request may close these issues.
7 participants
@sonjek @delvh @xanderxfz @lunny @yardenshoham @techknowlogick @GiteaBot