Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix users cannot visit issue attachment bug #25019

Merged
merged 2 commits into from
May 31, 2023

Conversation

lunny
Copy link
Member

@lunny lunny commented May 31, 2023

Caused by #24362

@lunny lunny added type/bug outdated/backport/v1.19 This PR should be backported to Gitea 1.19 labels May 31, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 31, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 31, 2023
@lunny lunny requested a review from jolheiser May 31, 2023 10:08
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 31, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 31, 2023
@jolheiser jolheiser added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 31, 2023
@silverwind silverwind merged commit 5d23c88 into go-gitea:main May 31, 2023
@GiteaBot GiteaBot added this to the 1.20.0 milestone May 31, 2023
GiteaBot added a commit to GiteaBot/gitea that referenced this pull request May 31, 2023
@GiteaBot GiteaBot added backport/done All backports for this PR have been created and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels May 31, 2023
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jun 1, 2023
* upstream/main:
  Fix users cannot visit issue attachment bug (go-gitea#25019)
  Fix incorrect issuel filter menu style (go-gitea#25018)
  Update repo's default branch when adding new files in an empty one (go-gitea#25017)
  Rename NotifyPullReviewRequest to NotifyPullRequestReviewRequest (go-gitea#24988)
  Merge `new project` templates into one (go-gitea#24985)
  Add chinese documentations for `cran package registry` (go-gitea#25012)
silverwind pushed a commit that referenced this pull request Jun 1, 2023
Backport #25019 by @lunny

Caused by #24362

Co-authored-by: Lunny Xiao <[email protected]>
Co-authored-by: John Olheiser <[email protected]>
@lunny lunny deleted the lunny/fix_issue_attachment_visit_bug branch June 1, 2023 23:07
Codeberg-org pushed a commit to Codeberg-org/gitea that referenced this pull request Jun 7, 2023
…a#25027)

Backport go-gitea#25019 by @lunny

Caused by go-gitea#24362

Co-authored-by: Lunny Xiao <[email protected]>
Co-authored-by: John Olheiser <[email protected]>
(cherry picked from commit 73ae6b2)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Aug 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. outdated/backport/v1.19 This PR should be backported to Gitea 1.19 size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants