Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arch packages implementation #25396

Closed
wants to merge 187 commits into from
Closed

Arch packages implementation #25396

wants to merge 187 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Jun 20, 2023

close #25037

This PR adds a package registry for Arch Linux packages with support for package files, signatures, and automatic pacman-database management.

Features:

  1. Push endpoints to upload package with or without signatures
  2. Delete endpoint for specific package version and all related files
  3. Get endpoint which is working for package files, gpg signature files and pacman database files
  4. Package UI with instructions to connect to the new pacman database and visualised package metadata

image

You can follow this tutorial to build a *.pkg.tar.zst package for testing

Co-authored-by: @KN4CK3R
Co-authored-by: @silverwind

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 20, 2023
@pull-request-size pull-request-size bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jun 20, 2023
@silverwind silverwind added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label Jun 20, 2023
@silverwind
Copy link
Member

The logo is not centered on its viewbox. Suggesting to replace it with https://www.svgrepo.com/svg/349296/arch-linux. I think we do use colored logos for other package types as well.

@silverwind
Copy link
Member

silverwind commented Jun 20, 2023

You need to put the source svg as web_src/svg/gitea-arch.svg and then run make svg to get a optimized svg with name gitea-arch generated into public/img/svg which also needs to be checked in.

routers/init.go Outdated Show resolved Hide resolved
Copy link
Member

@KN4CK3R KN4CK3R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some things to address:

  1. The routing should follow the current structure of other package types.
  2. The storage of blobs must use the existing system.

@GiteaBot GiteaBot added lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 21, 2023
@6543 6543 mentioned this pull request Jun 22, 2023
8 tasks
go.mod Outdated Show resolved Hide resolved
modules/packages/content_store.go Outdated Show resolved Hide resolved
Copy link
Member

@silverwind silverwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, can't really comment on go code though.

@ghost ghost marked this pull request as ready for review November 6, 2023 15:46
@ghost ghost marked this pull request as draft November 13, 2023 17:14
@p0da
Copy link

p0da commented Jan 14, 2024

Any update on this @d1nch8g?

@ghost
Copy link
Author

ghost commented Jan 18, 2024

@p0da

I am trying to add a package proxy and UI for different package files (should be easier to validate checksums).

@ExplodingDragon
Copy link
Contributor

Any new update on this @d1nch8g ?

@ghost
Copy link
Author

ghost commented Mar 18, 2024

@ExplodingDragon

Sorry for the delayed response. Not entirely sure about the proper way to implement package signature verification.

Ideally, that should be visible for each package file, along with checksums and other file-related properties, in an alike way as it is done with commit signatures.

@ExplodingDragon
Copy link
Contributor

@ExplodingDragon

Sorry for the delayed response. Not entirely sure about the proper way to implement package signature verification.

Ideally, that should be visible for each package file, along with checksums and other file-related properties, in an alike way as it is done with commit signatures.

This is not a problem if pacman can be skipped in the configuration file.

In fact, rpm module doesn't do anything about signing rpm packages file either. (#27069)

@github-actions github-actions bot added modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files labels May 13, 2024
@ghost ghost closed this by deleting the head repository May 13, 2024
ExplodingDragon added a commit to ExplodingDragon/gitea that referenced this pull request May 21, 2024
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Aug 11, 2024
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged modifies/api This PR adds API routes or modifies them modifies/docs modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files modifies/translation size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. topic/packages topic/ui Change the appearance of the Gitea UI type/docs This PR mainly updates/creates documentation type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Arch linux packages