Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct permissions for .ssh and authorized_keys (#25721) #25730

Merged
merged 1 commit into from
Jul 6, 2023
Merged

Correct permissions for .ssh and authorized_keys (#25721) #25730

merged 1 commit into from
Jul 6, 2023

Conversation

GiteaBot
Copy link
Contributor

@GiteaBot GiteaBot commented Jul 6, 2023

Backport #25721 by @wolfogre

Set the correct permissions on the .ssh directory and authorized_keys file, or sshd will refuse to use them and lead to clone/push/pull failures.

It could happen when users have copied their data to a new volume and changed the file permission by accident, and it would be very hard to troubleshoot unless users know how to check the logs of sshd which is started by s6.

@wolfogre @GiteaBot
Correct permissions for .ssh and authorized_keys (go-gitea#25721)
dc4b619 
Set the correct permissions on the .ssh directory and authorized_keys
file, or sshd will refuse to use them and lead to clone/push/pull
failures.

It could happen when users have copied their data to a new volume and
changed the file permission by accident, and it would be very hard to
troubleshoot unless users know how to check the logs of sshd which is
started by s6.

Co-authored-by: Giteabot <[email protected]>
@GiteaBot GiteaBot added the topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile label Jul 6, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 6, 2023
@GiteaBot GiteaBot added this to the 1.20.0 milestone Jul 6, 2023
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 6, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 6, 2023
@GiteaBot GiteaBot removed the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jul 6, 2023
@silverwind silverwind enabled auto-merge (squash) July 6, 2023 15:02
@GiteaBot GiteaBot added the lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. label Jul 6, 2023
@silverwind silverwind merged commit 09668b2 into go-gitea:release/v1.20 Jul 6, 2023
@silverwind silverwind added reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Jul 6, 2023
@wolfogre wolfogre mentioned this pull request Jul 7, 2023
Merged
hazycora pushed a commit to hazycora/gitea that referenced this pull request Sep 26, 2023
@earl-warren
[DOCS] RELEASE-NOTES.md
73b64ea 
(cherry picked from commit b07123ee7b441946bdeacf38dfbabde705427f63)
(cherry picked from commit ca85c880b476428b407c30b4b1776b2e008c9330)
(cherry picked from commit 723ead94cb63e8d703f0159a02e2fcaff2f1bb30)
(cherry picked from commit ff148318da221be77813675437026985a19107a7)

[DOCS] RELEASE-NOTES: 1.19.0

(cherry picked from commit e84e43887beae3a2f18afb8ef71fdc17078413bc)

[DOCS] RELEASE-NOTES: add scoped access tokens

(cherry picked from commit 688f831853ef179d511cc7594dd23cc46ccef654)

[DOCS] RELEASE-NOTES: Scoped labels

(cherry picked from commit 747479a07b3b7b329016337025eddbc82c4073a4)

[DOCS] RELEASE-NOTES: OIDC groups

(cherry picked from commit 10c505fe8941b81824f08e4c6a39d12517c182bc)

[DOCS] RELEASE-NOTES: Copy Link is broken

On firefox it fails with Uncaught TypeError: navigator.clipboard is
   undefined
On chromium it fails with Uncaught TypeError: Cannot read properties of undefined (reading 'writeText')

(cherry picked from commit 148b2ff093fa87672aa09d09484b7803bbdecc39)

[DOCS] RELEASE-NOTES: Copy citation

(cherry picked from commit d0f217735f506d0f4fb414f38860d821cd1925b5)

[DOCS] RELEASE-NOTES: Support org/user level projects

(cherry picked from commit de845c7bcf4637f442a612fafb6a663c7dc69473)

[DOCS] RELEASE-NOTES: v1.19 has a documentation

(cherry picked from commit 9a5b46da32fa12c32215a0c0a8b233c14a10c9b0)

[DOCS] RELEASE-NOTES: do not split webhook section

(cherry picked from commit 00ed02032124ca75644ec2365f054c56d7e68d20)

[DOCS] RELEASE-NOTES: Incoming emails

(cherry picked from commit 06c455b33bf39a7595a31a983dbaab7e28795f55)

[DOCS] RELEASE-NOTES: secrets are an implementation detail

(cherry picked from commit 8236dc3a573f9cdb892894416268d3a115c77fd1)

[DOCS] RELEASE-NOTES: Prohibit fork if user reached maximum

(cherry picked from commit 0f80b8c696ef8c407466605588f341b710a023ab)

[DOCS] RELEASE-NOTES: scoped tokens: do not duplicate the docs

(cherry picked from commit 9bc4793c078e115ab5d59fda89fb43765dcb0526)

[DOCS] RELEASE-NOTES: rss feed for tags and releases

(cherry picked from commit 599b36fada5f12a3fb4e0eed4f787606af701e46)

[DOCS] RELEASE-NOTES: protected branches wildcard

(cherry picked from commit 2b316c495056b9ae9191f51f550eb0a5c76ae6c1)

[DOCS] RELEASE-NOTES: disable releases

(cherry picked from commit 9a60773f1dcaf241b43707c2009e0223d0b3eed9)

[DOCS] RELEASE-NOTES: review box

(cherry picked from commit 09867dd1220c66c6ad468f9f0a0a22740510f373)

[DOCS] RELEASE-NOTES: asciicast support

(cherry picked from commit ea9658379b25f9c1dec487fd5d9139d37735e113)

[DOCS] RELEASE-NOTES: attention blocks

(cherry picked from commit 70b387750b2fea65e68aa2b1486ffcfef0dbd2fd)

[DOCS] RELEASE-NOTES: commit cross reference

(cherry picked from commit fe706dad13db9f3ad4fd6699b20337712e7a674b)

[DOCS] RELEASE-NOTES: strip user completion border case

(cherry picked from commit 33ca51b4b699ba347d395796d80eebab09b1a2f6)

[DOCS] RELEASE-NOTES: card preview

(cherry picked from commit 626cd78ca6d2c95dcd90c33d0f9e3e99f48912e7)

[DOCS] RELEASE-NOTES: raw copy button

(cherry picked from commit edfb467d64190df7b8056e5ced164678ea5a1ea7)

[DOCS] RELEASE-NOTES: allow edits by maintainers by default

(cherry picked from commit 7006405bc6113f4b7acd26d91d1f928022d00bdf)

[DOCS] RELEASE-NOTES: database auto migration is a little arcane

(cherry picked from commit 78030fa9af4a05e2092d54e18e7b2dee2037c299)

[DOCS] RELEASE-NOTES: fix typos & minor rewording

(cherry picked from commit ae1d47f656df2c11c140095d8710361ebe545af5)
(cherry picked from commit ad08ca9955304663367fa66e8d2097b78bc5b438)

[DOCS] RELEASE-NOTES: webhook authorization header

(cherry picked from commit c35e2c4f6f985be5763363ae2b03e5d23378f0d2)

[DOCS] RELEASE-NOTES: video element in markdown

(cherry picked from commit bcb0bd51d2114a7f086358b568928c3feeefea57)

[DOCS] RELEASE-NOTES: move scoped labels to the documentation

(cherry picked from commit c5eedaf4f398ca232ca65f132d504425dd8ac3ba)

[DOCS] RELEASE-NOTES: cosmetic improvements

(cherry picked from commit b93df350d96c0cb8b6b6b924a1dd8af1551f2263)

[DOCS] RELEASE-NOTES: 1.19.0-0 is really : 1.19.0-2

(cherry picked from commit 60d770c2c95d841c597f619e73582bbdfcdb0143)

[DOCS] RELEASE-NOTES: relevant repositories

(cherry picked from commit de6ed5b87f845bb86f4d3aa4085f373958797ebe)
(cherry picked from commit 71d91fdf22d04cb8d0c88eac87a9a59e1c558bd7)

[DOCS] RELEASE-NOTES: semantic version

(cherry picked from commit af062d77f0641426aa048e5975585b01652aea01)

[DOCS] RELEASE-NOTES: reflogs

(cherry picked from commit 084713d8aae787e2db76219f29840f006967ff92)
(cherry picked from commit 90ad322a56bd67f717e32e8a1a419033add3655a)

[DOCS] RELEASE-NOTES: fix broken link to OIDC mapping

(cherry picked from commit 802a252eb5ddb411574cd7a8c9645fffd88de469)

[DOCS] RELEASE-NOTES: Fix spaces

(cherry picked from commit a605d36ab63cba34770b14e0073ee6b9dbb3b511)

[DOCS] RELEASE-NOTES: SemVer

(cherry picked from commit 7b29c90035f243944340952c234e2caec84527e7)
(cherry picked from commit 82799195c9208d43a6c6d8da1fd6f7560f224b09)
(cherry picked from commit 5d9c2e9ec67ea7d39532d61bbf5aed3e1161d669)

[DOCS] RELEASE-NOTES: 1.19.0-3

(cherry picked from commit c599b2947d9da682da156fad459be76f09bda999)
(cherry picked from commit 8a37027ae78f42f211e179bc4080488485982a87)

[DOCS] RELEASE-NOTES: v1.19.1-0

(cherry picked from commit 89b9e96cc778a6cc2a063201252e9e2c1042a355)
(cherry picked from commit 2b4e881a4e43ea0ab522e4d8c127a2b4ccdb10d7)

[DOCS] RELEASE-NOTES: 1.19.2-0

(cherry picked from commit 0c0d2ec46cbc34d42b36af7e4096ee8e149a77ae)
(cherry picked from commit 437b8caae4d3045c00f671758dd287f005805cf6)

[DOCS] RELEASE-NOTES: 1.19.3-0

(cherry picked from commit 040740917e24c7d97ace3f46723e88163bafb533)

[DOCS] RELEASE-NOTES: 1.19.3-0 (fix typo)

(cherry picked from commit 24516cb22ab3768d076d5da87afa5f135e4409da)
(cherry picked from commit 429c8e652549072d0c695b7c3e7c9f447aea8b5b)
(cherry picked from commit 8247bddb45de2e5a275551d50a84ccfe5cc28e7d)
(cherry picked from commit d77d7b7be72d0de250d97cdedb9381a1cdc1562e)
(cherry picked from commit a64c899b1dde2ebeb620569b16cf982eb519e475)
(cherry picked from commit 0803eaa2e3b470f866e48fde7c6253666bfc5982)
(cherry picked from commit 8538f2897e49027e6f30e477401a97ddf22beb5b)
(cherry picked from commit 45b9037d3c0c243ffaab84b22d89e00371a2851e)
(cherry picked from commit 928705f)
(cherry picked from commit 19e683468c5bfaef5dc4c4a7cedbbdff3af7691c)
(cherry picked from commit 5ae55e8e347c015ca5ce50e10f49d2d509d070fa)
(cherry picked from commit 7c224d84cf1de8ce566533cbab48572735fce8ef)

[DOCS] RELEASE-NOTES: 1.20.0

(cherry picked from commit 3fbcdd235b67c2292162949b1fd24e4fe1a55753)
(cherry picked from commit e7a621acae5ce34c91db41848a4a2bc3e1fae6f6)
(cherry picked from commit 70adac6d6659de22a87f2bdbee7297f677fc7b51)

[DOCS] RELEASE-NOTES: 1.20.0-0-rc0 (squash) rewording

(cherry picked from commit 1b79fab57d370f65b1a22fdec264889044d6ec17)

[DOCS] RELEASE-NOTES: 1.20.0-0-rc0 (squash) time

(cherry picked from commit cfd599a13224f3413abf7e75859224f4e48a3028)

[DOCS] RELEASE-NOTES: 1.20.0-0-rc0 (squash) wiki

(cherry picked from commit 6aa2ab41c60af2bb348971bd5e1110f7abf98727)

pick changes from go-gitea#829

(cherry picked from commit f5995981015fda2d012597aacfddb62d2b328230)

[DOCS] RELEASE-NOTES: 1.20.0-0-rc0 (squash) ui

(cherry picked from commit 5f0aa769b1691b0f12273d8e48ffda67fbe0ed02)

features

(cherry picked from commit d1e788ff4e3eeb9cb07cfc7ceb682b7d8414ab89)

typos

(cherry picked from commit 088d4b2d61b6c8210cde54a1e001860d2ec0cebc)

Mirror Settings

(cherry picked from commit 161412affd711b6a6ea4e3284d791137c69a6e6a)

features

(cherry picked from commit 10cb0379e2c557d43ce17ef3153e877684605a58)

fix typo

(cherry picked from commit aee096b04098b5a2ecaa75a40701ea7ddf4ad022)

TODO

(cherry picked from commit 0d4e0bb4a973f7bd2f6653ff18f2f0830d04da18)

typo

(cherry picked from commit b76a3c1a84333699c292f33027a80099587322ff)
(cherry picked from commit 4c35419)
(cherry picked from commit 6323c6d1a28272f4694e9b213c25164ba1d03312)

[DOCS] RELEASE-NOTES: 1.20.0 (squash) Woodpecker CI archive repository

(cherry picked from commit 154ee5bc9c8a91980db646ce6f17da55445a111c)

[DOCS] RELEASE-NOTES: 1.20.0 (squash)

(cherry picked from commit 656f95544814cfcd6bd28e01e2baf5a524d4a273)

[DOCS] RELEASE-NOTES: 1.19.4-0

(cherry picked from commit 85bd99717683c53cbf133989a20323a7c4f993a9)

[DOCS] RELEASE-NOTES: 1.19.4-0 (squash) fix typo

(cherry picked from commit e5c364c586ef4b848b91a855ce62291780c37307)
(cherry picked from commit c123048e51a42167ade8feeba09c69d24f6ba5f6)
(cherry picked from commit ad2fedb6931df445b4a54a776144862ce78e023a)

[DOCS] RELEASE-NOTES: 1.20.0 (squash) blog

Pick changes from https://blog.gitea.com/release-of-1.20.0/

(cherry picked from commit c8068a9d7b93abbbc852a307f48dda0aef40db86)

[DOCS] RELEASE-NOTES: 1.20.0 (squash) Gitea release notes

Review https://github.com/go-gitea/gitea/releases/tag/v1.20.0

(cherry picked from commit dd58b50403894f84936e26680ce6791f045358e5)

[DOCS] RELEASE-NOTES: 1.20.0 (squash) commits

git log --no-merges --oneline 64ed262..gitea/release/v1.20 . ':(exclude,glob)docs/**' ':(exclude)CONTRIBUTING.md' ':(exclude)MAINTAINERS' ':(exclude,glob).github/**' ':(exclude)CHANGELOG.md' ':(exclude,glob)options/locale/**' ':(exclude,glob)options/license/**' ':(exclude,glob)snap/**' ':(exclude).drone.yml' ':(exclude)custom/conf/app.example.ini'

9159964 Avoid opening/closing PRs which are already merged (go-gitea#25883) (go-gitea#25903)
9369b38 Skip unuseful error message in dev mode when watching local filesystem (go-gitea#25919) (go-gitea#25927)
6e82d0b Add shutting down notice (go-gitea#25920) (go-gitea#25922)
36b9a86 Fix incorrect milestone count when provide a keyword (go-gitea#25880) (go-gitea#25904)
de8127e fix incorrect repo url when changed the case of ownername (go-gitea#25733) (go-gitea#25881)
de8127e fix incorrect repo url when changed the case of ownername (go-gitea#25733) (go-gitea#25881)
186f07b Make `add line comment` buttons focusable (go-gitea#25894) (go-gitea#25896)
45b1f4d Add support for different Maven POM encoding (go-gitea#25873) (go-gitea#25890)
026e745 Fix incorrect release count (go-gitea#25879) (go-gitea#25887)
c334be8 Fix empty project displayed in issue sidebar (go-gitea#25802) (go-gitea#25854)
353dcc5 Fix the error message when the token is incorrect (go-gitea#25701) (go-gitea#25836)
abe9c64 Show correct SSL Mode on "install page" (go-gitea#25818) (go-gitea#25838)
052e65e Fix incorrect oldest sort in project list (go-gitea#25806) (go-gitea#25835)
c1a10be Fix activity type match in `matchPullRequestEvent` (go-gitea#25746) (go-gitea#25796)
2b79d3f For API attachments, use API URL (go-gitea#25639) (go-gitea#25814)
b4460cf Make "install page" respect environment config (go-gitea#25648) (go-gitea#25799)
a1bc2aa Avoid amending the Rebase and Fast-forward merge if there is no message template (go-gitea#25779) (go-gitea#25809)
d713cf6 Fix WORK_DIR for docker (root) image (go-gitea#25738) (go-gitea#25811)
012b804 Clarify "text-align" CSS helpers, fix clone button padding (go-gitea#25763) (go-gitea#25764)
372b622 Revert package access change from go-gitea#23879 (go-gitea#25707) (go-gitea#25785)
06bcdfe Remove unused code (go-gitea#25734) (go-gitea#25788)
a5a3c81 Fix notification list bugs (go-gitea#25781) (go-gitea#25787)
ea2c9de Test if container blob is accessible before mounting (go-gitea#22759) (go-gitea#25784)
348a6bf Always pass 6-digit hex color to monaco (go-gitea#25780) (go-gitea#25782)
91daded Translate untranslated string in issues list (go-gitea#25759) (go-gitea#25761)
32eaba1 Hide `add file` button for pull mirrors (go-gitea#25748) (go-gitea#25751)
917ca5d Several fixes for mobile UI (go-gitea#25634) (go-gitea#25689)
e595dfe Allow/fix review (approve/reject) of empty PRs (go-gitea#25690) (go-gitea#25732)
03cacf9 Check `ctx.Written()` for `GetActionIssue` (go-gitea#25698) (go-gitea#25711)
68e0c80 Show correct naming for 1 comment (go-gitea#25704) (go-gitea#25712)
09668b2 Correct permissions for `.ssh` and `authorized_keys` (go-gitea#25721) (go-gitea#25730)
04eea29 Fix tags header and pretty format numbers (go-gitea#25624) (go-gitea#25694)
511be9f Fix position of org follow button (go-gitea#25688) (go-gitea#25692)
24e64fe Replace `interface{}` with `any` (go-gitea#25686) (go-gitea#25687)
4e31013 Prevent duplicate image loading (go-gitea#25675) (go-gitea#25684)
491f36d Actions list enhancements (go-gitea#25601) (go-gitea#25678)
5510ed3 Fix the nil pointer when assigning issues to projects (go-gitea#25665) (go-gitea#25677)
39fce57 Prevent SVG shrinking (go-gitea#25652) (go-gitea#25669)
1f90376 Fix show more for image on diff page (go-gitea#25672) (go-gitea#25673)
0af6542 Add unit test for repository collaboration (go-gitea#25640) (go-gitea#25658)
69bdcf4 Log the real reason when authentication fails (but don't show the user) (go-gitea#25414) (go-gitea#25660)
e610b03 Fix UI misalignment on user setting page (go-gitea#25629) (go-gitea#25656)
13ffa28  Fix bug of branches API with tests(go-gitea#25578) (go-gitea#25579)

(cherry picked from commit 3e9e862e5ed30e82f3b4da1b14f7865fb05464e4)

[DOCS] RELEASE-NOTES: 1.20.0 (squash) reorder breaking

(cherry picked from commit 4e4cdddc5549caa62629955b3803fcf808219c2e)

address rome-user review

(cherry picked from commit 8791fe88b1653ce536ba0596b2defcc6d80fbff1)

[DOCS] RELEASE-NOTES: 1.20.0 (squash) reword breaking

- removed the section about the changed themes: it is an internal
detail and redundant with the above warning regarding themes &
templates

(cherry picked from commit b34e9a7b19e445639144a4cd5371ae23cf0dc77d)

[DOCS] RELEASE-NOTES: 1.20.0 (squash) minor rewording

The CI & Actions sections were grouped together.

(cherry picked from commit ed236e1ee89eeecfaee28fe44e738dc2d96592b3)

[DOCS] RELEASE-NOTES: 1.20.1-0 (squash)

(cherry picked from commit 3c11eb1de542e2c56446108aec9b3b4d3cb8c117)

[DOCS] RELEASE-NOTES: 1.20.1-0 (squash) Forgejo features/optimizations

(cherry picked from commit c516fd0c7a8251420b5fdbc1e27083ae8a552560)

[DOCS] RELEASE-NOTES: 1.20.1-0 (squash) fix typo in Alpine version

(cherry picked from commit 1c2a5b516203db744364387e6d5673c65341f8ac)

[DOCS] RELEASE-NOTES: 1.20.1-0 (squash) comment out obsoleted queue keys

(cherry picked from commit 8c0d9459c5e1fde85bb6e728e53ce137a87dd69d)

[DOCS] RELEASE-NOTES: 1.20.1-0 (squash) WORK_PATH breaking change

(cherry picked from commit f4ea3b27f51fb2ecfb9d08bb3547fea067afa766)
(cherry picked from commit 0557568f613fe072df32c1620bb7e0e060bdd71a)

[DOCS] RELEASE-NOTES.md (squash) obsolete queue `app.ini` keys

(cherry picked from commit e0c943ac3bbd7779c56e77225829eb3ce46b6c93)

[DOCS] RELEASE-NOTES.md (squash) v1.20.2-0

(cherry picked from commit f2c654d1c8f0ed983db7374936962753f430523b)

[DOCS] RELEASE-NOTES.md (squash) fix LFS issue link

(cherry picked from commit 2461355f2a372229b41a2326ac50bfc7c26a3244)
(cherry picked from commit 750652d75ab408736a2b3be77404163087f98a4e)
(cherry picked from commit 6899dbdc118da8cbae2f986f1601ae228926c4e5)
(cherry picked from commit 88b988d08447d46010e885f703c3890c252e200e)

[DOCS] RELEASE-NOTES.md (squash) v1.20.3-0

(cherry picked from commit d566e78d68e79af56a1ed40e25e95f8ad612790c)
(cherry picked from commit 65439eafa43683b304606a06b7c1bbed6f2bdbe9)
(cherry picked from commit a76cc5b8bcbcefc7a54ee9b0381dcb54cb3fe5bf)
(cherry picked from commit b4e1ad6020ccb107da6e005af3a1bf182d735930)

[DOCS] RELEASE-NOTES.md (squash) v1.20.4-0

(cherry picked from commit 8a910c0c339faa59d46a6d838b5614b6f04a5e61)

[DOCS] RELEASE-NOTES.md (squash) link to upgrade docs

Refs: https://codeberg.org/forgejo/forgejo/issues/1199
(cherry picked from commit d4e9030873d2a3ae6dd379837aa1026a30a50aa2)
(cherry picked from commit 7da7b9cef4711fab8a35e477743b6fdc8cce70ce)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Oct 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@denyskon denyskon denyskon approved these changes

@silverwind silverwind silverwind approved these changes

@delvh delvh Awaiting requested review from delvh

@lunny lunny Awaiting requested review from lunny

Assignees

@wolfogre wolfogre

Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile
Projects
None yet
Milestone
1.20.0
Development

Successfully merging this pull request may close these issues.
4 participants
@GiteaBot @silverwind @denyskon @wolfogre