Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide add file button for pull mirrors #25748

Merged
merged 2 commits into from
Jul 7, 2023
Merged

Hide add file button for pull mirrors #25748

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2d027ad
hide btn for mirror repo
hiifong Jul 7, 2023
b6c6305
Merge branch 'main' into hide_btn_mirror_repo
GiteaBot Jul 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion templates/repo/home.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@
<a href="{{.Repository.Link}}/find/{{.BranchNameSubURL}}" class="ui compact basic button">{{.locale.Tr "repo.find_file.go_to_file"}}</a>
{{end}}

{{if and .CanWriteCode .IsViewBranch (not .Repository.IsArchived) (not .IsViewFile)}}
{{if and .CanWriteCode .IsViewBranch (not .Repository.IsMirror) (not .Repository.IsArchived) (not .IsViewFile)}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is IsMirror only true for pull mirrors, or also for push mirrors?
If yes, this will introduce a bug for push mirrors.
Either way, we should fix this inconsistency eventually.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not tested push mirrors

Copy link
Member

@silverwind silverwind Jul 7, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How it could be:

IsMirror -> either push or pull
IsPushMirror -> push
IsPullMirror -> pull

Even better, could be explicit and remove isMirror to force the user to think about it. But it might be that customization templates rely on this variable, making the PR at least unsuitable for backport.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how do create a push mirror

Copy link
Contributor

@wxiaoguang wxiaoguang Jul 7, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a legacy problem. In old ages, there was only "pull mirror", so IsMirror always means pull mirror.

Later, when adding "push mirror", the name is always "push mirror".

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how do create a push mirror

repo settings > repository > mirror settings

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, push mirrors should enable the button.
Only pull mirrors cannot add anything at the moment as far as I know.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is push mirror:
image

<button class="ui dropdown basic compact jump button gt-mr-2"{{if not .Repository.CanEnableEditor}} disabled{{end}}>
{{.locale.Tr "repo.editor.add_file"}}
{{svg "octicon-triangle-down" 14 "dropdown icon"}}
Expand Down