Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak repo topics bar #25769

Merged
merged 4 commits into from
Jul 8, 2023
Merged

Tweak repo topics bar #25769

merged 4 commits into from
Jul 8, 2023

Conversation

silverwind
Copy link
Member

Minor tweaks to repo topics:

  • Use gap instead of margin to align "Manage Topics" when no topics present
  • Add margin to description instead

Before:

Screenshot 2023-07-08 at 13 08 15 Screenshot 2023-07-08 at 13 08 05

After:

Screenshot 2023-07-08 at 13 08 42 Screenshot 2023-07-08 at 13 08 32

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 8, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 8, 2023
@silverwind silverwind added type/enhancement An improvement of existing functionality skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Jul 8, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 8, 2023
@puni9869
Copy link
Member

puni9869 commented Jul 8, 2023

Is this the change made
image
image

Just want to confirm

@silverwind
Copy link
Member Author

silverwind commented Jul 8, 2023

Is this the change made

Sorry, I don't understand the question.

Some more small tweaks done, here are all three variants of the view:

Screenshot 2023-07-08 at 13 20 34 Screenshot 2023-07-08 at 13 20 21 Screenshot 2023-07-08 at 13 20 07

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 8, 2023
@lafriks lafriks enabled auto-merge (squash) July 8, 2023 17:40
@lafriks lafriks merged commit f8bb101 into go-gitea:main Jul 8, 2023
23 checks passed
@GiteaBot GiteaBot added this to the 1.21.0 milestone Jul 8, 2023
@lunny lunny added reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Jul 9, 2023
@silverwind silverwind deleted the repotopics branch July 9, 2023 09:08
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jul 10, 2023
* giteaofficial/main: (31 commits)
  Fix WORK_DIR for docker (root) image (go-gitea#25738)
  Avoid amending the Rebase and Fast-forward merge if there is no message template (go-gitea#25779)
  Show edit title button on commits tab of PR, too (go-gitea#25791)
  Make "install page" respect environment config (go-gitea#25648)
  Enable H014 and H023 djlint rules (go-gitea#25786)
  Restructure issue list template, styles (go-gitea#25750)
  Fix notification list bugs (go-gitea#25781)
  Revert package access change from go-gitea#23879 (go-gitea#25707)
  Make route middleware/handler mockable (go-gitea#25766)
  Update tool dependencies, lock govulncheck and actionlint (go-gitea#25655)
  Test if container blob is accessible before mounting (go-gitea#22759)
  Always pass 6-digit hex color to monaco (go-gitea#25780)
  Fix the wrong default branch name displayed by checkout (go-gitea#25777)
  Tweak repo topics bar (go-gitea#25769)
  docs: rootless docker ssh's default port is 2222 (go-gitea#25771)
  Repository Archived text title center align (go-gitea#25767)
  Update JS dependencies, misc tweaks (go-gitea#25768)
  Clarify "text-align" CSS helpers, fix clone button padding (go-gitea#25763)
  Switch to `vite-string-plugin` (go-gitea#25762)
  Newly pushed branches hints on repository home page (go-gitea#25715)
  ...
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Oct 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants