Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use template context function for avatar rendering #26385

Merged
merged 6 commits into from
Aug 10, 2023
Merged

Use template context function for avatar rendering #26385

merged 6 commits into from
Aug 10, 2023

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Aug 8, 2023 •
edited
Loading

Introduce AvatarUtils, no need to pass $.Context to every sub-template, and simplify the template helper functions.

Some functions like avatarHTML they do not need to use context, so they are left in the template helpers, they could be refactored in a separate PR.

@wxiaoguang wxiaoguang added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Aug 8, 2023
@wxiaoguang wxiaoguang added this to the 1.21.0 milestone Aug 8, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 8, 2023
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 8, 2023
silverwind
silverwind approved these changes Aug 9, 2023
View reviewed changes
Copy link
Member

@silverwind silverwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thanks.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 9, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 10, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Aug 10, 2023
@wxiaoguang wxiaoguang merged commit a370efc into go-gitea:main Aug 10, 2023
23 checks passed
@wxiaoguang wxiaoguang deleted the use-ctx-avatar branch August 10, 2023 03:19
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Aug 10, 2023
zjjhot added a commit to zjjhot/gitea that referenced this pull request Aug 10, 2023
@zjjhot
Merge remote-tracking branch 'upstream/main'
4115a88 
* upstream/main:
  Use template context function for avatar rendering (go-gitea#26385)
  Add transaction when creating pull request created dirty data (go-gitea#26259)
  Fix admin queue page title (go-gitea#26409)
@wxiaoguang wxiaoguang mentioned this pull request Sep 13, 2023
Merged
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Nov 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silverwind silverwind silverwind approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.21.0
Development

Successfully merging this pull request may close these issues.
4 participants
@wxiaoguang @lunny @silverwind @GiteaBot