Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call git.InitSimple for runRepoSyncReleases #26396

Merged
merged 3 commits into from
Aug 10, 2023
Merged

Call git.InitSimple for runRepoSyncReleases #26396

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f0d88c7
fix
wxiaoguang Aug 8, 2023
26a9c12
Merge branch 'main' into fix-cmd-git-init
wxiaoguang Aug 9, 2023
b82b014
Merge branch 'main' into fix-cmd-git-init
wxiaoguang Aug 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions cmd/admin.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,6 +355,10 @@ func runRepoSyncReleases(_ *cli.Context) error {
return err
}

if err := git.InitSimple(ctx); err != nil {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this function should short-circuit if it is already initialized.
So, wrap its content in a once.Do?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was designed to be so because it came from some old code.

At the moment, everything is under control.

image

return err
}

log.Trace("Synchronizing repository releases (this may take a while)")
for page := 1; ; page++ {
repos, count, err := repo_model.SearchRepositoryByName(ctx, &repo_model.SearchRepoOptions{
Expand Down