Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor] getIssueStatsChunk to move inner function into own one #26671

Merged
merged 3 commits into from
Aug 23, 2023
Merged

[Refactor] getIssueStatsChunk to move inner function into own one #26671

merged 3 commits into from
Aug 23, 2023

Conversation

6543
Copy link
Member

@6543 6543 commented Aug 22, 2023

move inner countSession of getIssueStatsChunk into it's own function for reuse

Sponsored by Kithara Software GmbH

@6543 6543 added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Aug 22, 2023
@6543 6543 added this to the 1.21.0 milestone Aug 22, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 22, 2023
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 22, 2023
@6543
Copy link
Member Author

6543 commented Aug 22, 2023 •
edited
Loading

review tip: hide whitespaces -> https://github.com/go-gitea/gitea/pull/26671/files?diff=unified&w=1

@6543 6543 mentioned this pull request Aug 22, 2023
Merged
2 tasks
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 22, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 23, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Aug 23, 2023
@techknowlogick techknowlogick merged commit 3a67997 into go-gitea:main Aug 23, 2023
24 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Aug 23, 2023
zjjhot added a commit to zjjhot/gitea that referenced this pull request Aug 23, 2023
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
a34a70c 
* giteaofficial/main:
  Fix counting and filtering on the dashboard page for issues (go-gitea#26657)
  add mfa doc (go-gitea#26654)
  [Refactor] getIssueStatsChunk to move inner function into own one (go-gitea#26671)
  Use line-height: normal by default (go-gitea#26635)
  Improve repo sub menu (go-gitea#26531)
  Fix organization list in dashboard (go-gitea#26650)
@6543 6543 deleted the upstream_refactoring_milestone_stats branch August 23, 2023 02:41
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Nov 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.21.0
Development

Successfully merging this pull request may close these issues.
5 participants
@6543 @lunny @delvh @techknowlogick @GiteaBot