WIP: Use websocket for notification instead of eventsource

[lunny]

No description provided.

[silverwind]

Good choice with melody, it's something I've been eyeing as well because of easy broadcasts.

[silverwind]

Suggested change

	const url = 'ws://' + window.location.host + '/ws';
	const ws = new WebSocket(url);
	const ws = new WebSocket(`${window.location.origin.replace(/^http/, 'ws')}/ws`);

So it works on HTTPS as well. Should move this code to a separate modules/websocket.js file later.

[lunny]

Good choice with melody, it's something I've been eyeing as well because of easy broadcasts.

I just found melody has a memory switch system so I may change it back to gorilla/websocket directly.

[silverwind]

I just found melody has a memory switch system

What do you mean? It seems pretty bare-bone: https://github.com/olahol/melody/blob/master/melody.go

[yardenshoham]

What are the implications for the helm chart?

cc @pat-s

[silverwind]

Reverse proxies may need adjustment to pass through Websockets unharmed. For nginx specifically:

proxy_set_header Upgrade $http_upgrade;
proxy_set_header Connection $http_connection;

[pat-s]

@lunny Do you plans to continue here?

[lunny]

@lunny Do you plans to continue here?

Yes. I will send some code recently. We need a pub/sub interfaces/services on server side.