Display archived labels specially when listing labels #26820

puni9869 · 2023-08-30T11:06:51Z

Follow up #26741

Changes:
Added archived label for org labels and added into issue filter list.

Part of #25237

Signed-off-by: puni9869 <[email protected]>

…ilter

delvh

Good enough for now.
We can still add a better implementation once 1.21 has been released.

templates/repo/issue/filters.tmpl

wxiaoguang

Not a blocker, but italic seems a little strange to me. IIRC there were seldom such style before?

…ilter

silverwind · 2023-08-31T21:04:39Z

Now you made it look like a button. How about a label like this? Could even downsize it a bit if it seems too big.

puni9869 · 2023-08-31T22:26:08Z

Now you made it look like a button. How about a label like this? Could even downsize it a bit if it seems too big.

i can do that

…ilter

silverwind · 2023-09-01T09:42:31Z

Keep it right-aligned, I like that.

puni9869 · 2023-09-01T09:59:47Z

My best effort.

silverwind · 2023-09-01T10:05:21Z

Seems like we should really subtemplate these basic labels. They are used the same in many places, except admin repolist I think where they are downsized a bit. This would blow the PR a bit out of proportion, though.

puni9869 · 2023-09-16T15:27:01Z

@silverwind styles are overriding. I tried but not successful. Could you hack it.

delvh · 2023-09-16T20:34:18Z

@silverwind do you mean the label should only be outlined?
Or what do you mean?
For now, I'm happy with any appearance as this PR should be merged before releasing 1.21.0-rc0…

silverwind · 2023-09-17T23:15:46Z

Yes, it's style pollution coming from .ui.secondary.labels .label, .ui.ui.ui.secondary.label. The labels class there is unintended.

Another issue is the archived state does not show in the issue/pr sidebar selector.

silverwind · 2023-09-17T23:23:37Z

Fixed style in 1e01b58:

It would be nice if we could show archived state in issue/pr dropdown too, but I guess if you want to merge it before that, go ahead.

puni9869 · 2023-09-18T03:07:48Z

many thanks silvermind

puni9869 · 2023-09-18T03:45:27Z

Are you pointing here

silverwind · 2023-09-18T09:28:50Z

Yes, that list of labels there needs to share a subtemplate with the one on the list. Overall I would like to refactor it to not be so ugly and use a style similar to GitHub.

puni9869 · 2023-09-18T11:29:28Z

No worries I have something good in mind about label filter UI, will share soon once I develop this feature. Less work is left in this feature.

* origin/main: Fix the incorrect route path in the user edit page. (go-gitea#27007) Refactor lfs requests (go-gitea#26783) Display archived labels specially when listing labels (go-gitea#26820) Remove a `gt-float-right` and some unnecessary helpers (go-gitea#27110) [skip ci] Updated licenses and gitignores Fix token endpoints ignore specified account (go-gitea#27080) Make SSPI auth mockable (go-gitea#27036)

* giteaofficial/main: Improve actions docs related to `pull_request` event (go-gitea#27126) Remove outdated paragraphs when comparing Gitea Actions to GitHub Actions (go-gitea#27119) Fix: treat tab "overview" as "repositories" in user profiles without readme (go-gitea#27124) Fix incorrect test code for error handling (go-gitea#27139) Increase auth provider icon size on login page (go-gitea#27122) fix pagination for followers and following (go-gitea#27127) services/wiki: Close() after error handling (go-gitea#27129) Use fetch helpers instead of fetch (go-gitea#27026) Change green buttons to primary color (go-gitea#27099) Fix wrong xorm get usage on migration (go-gitea#27111) Fix the incorrect route path in the user edit page. (go-gitea#27007) Refactor lfs requests (go-gitea#26783) Display archived labels specially when listing labels (go-gitea#26820) Remove a `gt-float-right` and some unnecessary helpers (go-gitea#27110) [skip ci] Updated licenses and gitignores Fix token endpoints ignore specified account (go-gitea#27080) Make SSPI auth mockable (go-gitea#27036)

Followup #26820 ## Archived labels UI for issue filter and issue filter actions for issues/pull request pages. Changed: * Enhanced the Issue filter and Issue filter actions UI page to seamlessly incorporate a list of archived labels. * Pagination functionality is same as before. If archived label checkbox is checked then we are adding a query string`archived=true` in the url to save the state of page. * Issue filter actions menu is separated into different template. * Adding the archived flag in issue url labels. * Pull Request page is also work the same. Outsourced: * Defer the implementation of specialized handling for archived labels to upcoming pull requests. This step will be undertaken subsequent to the successful merge of this pull request. Screenshots ### Issue page <img width="1360" alt="image" src="https://github.com/go-gitea/gitea/assets/80308335/d7efb2ef-5b2b-449d-83f0-d430a32ec432"> ### Issue page with label filter on archived label checkbox when not checked --> No archived label is there in list <img width="1249" alt="image" src="https://github.com/go-gitea/gitea/assets/80308335/ceea68ef-91f2-4693-910f-2e25e236bfc9"> ### Issue page with label filter on archived label checkbox when checked --> Show archived label in the list. <img width="710" alt="image" src="https://github.com/go-gitea/gitea/assets/80308335/2414d26b-2079-4c3c-bd9e-f2f5411bcabf"> ### Issue page with label filter on issue action menu on archived label checkbox when checked --> Show archived label in the list. <img width="409" alt="image" src="https://github.com/go-gitea/gitea/assets/80308335/259cac87-3e21-4778-99a2-a6a0b8c81178"> ### Applied the archived=true in Issue labels when archived checkbox is checked. <img width="984" alt="image" src="https://github.com/go-gitea/gitea/assets/80308335/657ce3db-c0ae-402e-b12d-3b580d3c2ed0"> --- Part of #25237 --------- Signed-off-by: puni9869 <[email protected]> Co-authored-by: delvh <[email protected]> Co-authored-by: Giteabot <[email protected]>

…itea#27115) Followup go-gitea#26820 ## Archived labels UI for issue filter and issue filter actions for issues/pull request pages. Changed: * Enhanced the Issue filter and Issue filter actions UI page to seamlessly incorporate a list of archived labels. * Pagination functionality is same as before. If archived label checkbox is checked then we are adding a query string`archived=true` in the url to save the state of page. * Issue filter actions menu is separated into different template. * Adding the archived flag in issue url labels. * Pull Request page is also work the same. Outsourced: * Defer the implementation of specialized handling for archived labels to upcoming pull requests. This step will be undertaken subsequent to the successful merge of this pull request. Screenshots ### Issue page <img width="1360" alt="image" src="https://github.com/go-gitea/gitea/assets/80308335/d7efb2ef-5b2b-449d-83f0-d430a32ec432"> ### Issue page with label filter on archived label checkbox when not checked --> No archived label is there in list <img width="1249" alt="image" src="https://github.com/go-gitea/gitea/assets/80308335/ceea68ef-91f2-4693-910f-2e25e236bfc9"> ### Issue page with label filter on archived label checkbox when checked --> Show archived label in the list. <img width="710" alt="image" src="https://github.com/go-gitea/gitea/assets/80308335/2414d26b-2079-4c3c-bd9e-f2f5411bcabf"> ### Issue page with label filter on issue action menu on archived label checkbox when checked --> Show archived label in the list. <img width="409" alt="image" src="https://github.com/go-gitea/gitea/assets/80308335/259cac87-3e21-4778-99a2-a6a0b8c81178"> ### Applied the archived=true in Issue labels when archived checkbox is checked. <img width="984" alt="image" src="https://github.com/go-gitea/gitea/assets/80308335/657ce3db-c0ae-402e-b12d-3b580d3c2ed0"> --- Part of go-gitea#25237 --------- Signed-off-by: puni9869 <[email protected]> Co-authored-by: delvh <[email protected]> Co-authored-by: Giteabot <[email protected]>

@puni9869

…) (#27381) Backport #27115 by @puni9869 Followup #26820 ## Archived labels UI for issue filter and issue filter actions for issues/pull request pages. Changed: * Enhanced the Issue filter and Issue filter actions UI page to seamlessly incorporate a list of archived labels. * Pagination functionality is same as before. If archived label checkbox is checked then we are adding a query string`archived=true` in the url to save the state of page. * Issue filter actions menu is separated into different template. * Adding the archived flag in issue url labels. * Pull Request page is also work the same. Outsourced: * Defer the implementation of specialized handling for archived labels to upcoming pull requests. This step will be undertaken subsequent to the successful merge of this pull request. Screenshots ### Issue page <img width="1360" alt="image" src="https://github.com/go-gitea/gitea/assets/80308335/d7efb2ef-5b2b-449d-83f0-d430a32ec432"> ### Issue page with label filter on archived label checkbox when not checked --> No archived label is there in list <img width="1249" alt="image" src="https://github.com/go-gitea/gitea/assets/80308335/ceea68ef-91f2-4693-910f-2e25e236bfc9"> ### Issue page with label filter on archived label checkbox when checked --> Show archived label in the list. <img width="710" alt="image" src="https://github.com/go-gitea/gitea/assets/80308335/2414d26b-2079-4c3c-bd9e-f2f5411bcabf"> ### Issue page with label filter on issue action menu on archived label checkbox when checked --> Show archived label in the list. <img width="409" alt="image" src="https://github.com/go-gitea/gitea/assets/80308335/259cac87-3e21-4778-99a2-a6a0b8c81178"> ### Applied the archived=true in Issue labels when archived checkbox is checked. <img width="984" alt="image" src="https://github.com/go-gitea/gitea/assets/80308335/657ce3db-c0ae-402e-b12d-3b580d3c2ed0"> --- Part of #25237 Signed-off-by: puni9869 <[email protected]> Co-authored-by: puni9869 <[email protected]> Co-authored-by: delvh <[email protected]>

Added archived label for org labels and added into issue filter list.

530806f

Signed-off-by: puni9869 <[email protected]>

GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 30, 2023

pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 30, 2023

Merge branch 'go-gitea:main' into punit/Showing-archive-label-issue-f…

9bf387a

…ilter

puni9869 added this to the 1.21.0 milestone Aug 30, 2023

puni9869 added the topic/ui Change the appearance of the Gitea UI label Aug 30, 2023

Merge branch 'main' into punit/Showing-archive-label-issue-filter

9b94b4f

delvh reviewed Aug 30, 2023

View reviewed changes

templates/repo/issue/filters.tmpl Outdated Show resolved Hide resolved

templates/repo/issue/filters.tmpl Outdated Show resolved Hide resolved

wxiaoguang reviewed Aug 31, 2023

View reviewed changes

puni9869 and others added 4 commits August 31, 2023 11:51

Merge branch 'go-gitea:main' into punit/Showing-archive-label-issue-f…

14d4646

…ilter

Merge branch 'main' into punit/Showing-archive-label-issue-filter

6f61aef

Merge branch 'main' into punit/Showing-archive-label-issue-filter

404f4dd

Ui fixes and changing archived label hint and ui

d8866d7

pull-request-size bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 31, 2023

puni9869 marked this pull request as draft August 31, 2023 11:40

Translations change

fcee97b

puni9869 marked this pull request as ready for review August 31, 2023 14:42

puni9869 marked this pull request as draft August 31, 2023 15:29

puni9869 and others added 2 commits August 31, 2023 21:06

Reordering the archive hint in org labels

f1168a4

Merge branch 'go-gitea:main' into punit/Showing-archive-label-issue-f…

32f3917

…ilter

puni9869 added 2 commits September 1, 2023 12:17

Merge branch 'go-gitea:main' into punit/Showing-archive-label-issue-f…

6e137e5

…ilter

Merge branch 'main' into punit/Showing-archive-label-issue-filter

df8ab39

Styling the label in label page and issue filter

541f1a4

Linter

4b51542

Merge branch 'main' into punit/Showing-archive-label-issue-filter

3682eb8

override problematic style

1e01b58

silverwind approved these changes Sep 17, 2023

View reviewed changes

GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 17, 2023

Merge branch 'main' into punit/Showing-archive-label-issue-filter

b5919f3

puni9869 added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Sep 18, 2023

Merge branch 'main' into punit/Showing-archive-label-issue-filter

6117f22

lunny enabled auto-merge (squash) September 18, 2023 04:26

lunny merged commit a50d9af into go-gitea:main Sep 18, 2023
25 checks passed

GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Sep 18, 2023

puni9869 deleted the punit/Showing-archive-label-issue-filter branch September 18, 2023 05:03

puni9869 mentioned this pull request Sep 24, 2023

Hide archived labels when filtering by labels on the issue list #27115

Merged

GiteaBot mentioned this pull request Oct 1, 2023

Hide archived labels when filtering by labels on the issue list (#27115) #27381

Merged

puni9869 mentioned this pull request Oct 5, 2023

Hide archived labels by default from the suggestions when assigning labels for an issue #27451

Merged

go-gitea locked as resolved and limited conversation to collaborators Dec 17, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Display archived labels specially when listing labels #26820

Display archived labels specially when listing labels #26820

puni9869 commented Aug 30, 2023 •

edited

Loading

delvh left a comment

wxiaoguang left a comment

silverwind commented Aug 31, 2023

puni9869 commented Aug 31, 2023

silverwind commented Sep 1, 2023

puni9869 commented Sep 1, 2023

silverwind commented Sep 1, 2023

puni9869 commented Sep 16, 2023

delvh commented Sep 16, 2023

silverwind commented Sep 17, 2023

silverwind commented Sep 17, 2023

puni9869 commented Sep 18, 2023

puni9869 commented Sep 18, 2023

silverwind commented Sep 18, 2023 •

edited

Loading

puni9869 commented Sep 18, 2023

Display archived labels specially when listing labels #26820

Display archived labels specially when listing labels #26820

Conversation

puni9869 commented Aug 30, 2023 • edited Loading

delvh left a comment

Choose a reason for hiding this comment

wxiaoguang left a comment

Choose a reason for hiding this comment

silverwind commented Aug 31, 2023

puni9869 commented Aug 31, 2023

silverwind commented Sep 1, 2023

puni9869 commented Sep 1, 2023

silverwind commented Sep 1, 2023

puni9869 commented Sep 16, 2023

delvh commented Sep 16, 2023

silverwind commented Sep 17, 2023

silverwind commented Sep 17, 2023

puni9869 commented Sep 18, 2023

puni9869 commented Sep 18, 2023

silverwind commented Sep 18, 2023 • edited Loading

puni9869 commented Sep 18, 2023

puni9869 commented Aug 30, 2023 •

edited

Loading

silverwind commented Sep 18, 2023 •

edited

Loading