Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Users with read permission of pull requests can be assigned too #27263

Merged
merged 6 commits into from
Feb 24, 2024
Merged

Users with read permission of pull requests can be assigned too #27263

merged 6 commits into from
Feb 24, 2024

Conversation

lunny
Copy link
Member

@lunny lunny commented Sep 25, 2023 •
edited
Loading

This PR will also keep the consistent between list assigned users and check assigned users.

@lunny lunny added type/enhancement An improvement of existing functionality backport/v1.21 This PR should be backported to Gitea 1.21 labels Sep 25, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 25, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 25, 2023
@lunny lunny added this to the 1.22.0 milestone Sep 25, 2023
@lunny lunny added the type/bug label Sep 26, 2023
@lunny lunny added kind/bugfix and removed type/bug labels Oct 7, 2023
@delvh delvh added type/bug and removed kind/bugfix labels Oct 7, 2023
@lunny lunny changed the title Those have read permission of pull request should be assigneed Those have read permission of pull request should be assignable Nov 4, 2023
@denyskon denyskon added the giteabot/update-branch Hint for the bot that it should update a PR with the latest state on main label Dec 25, 2023
@denyskon denyskon self-requested a review December 25, 2023 19:53
@GiteaBot GiteaBot removed the giteabot/update-branch Hint for the bot that it should update a PR with the latest state on main label Dec 25, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 24, 2024
@delvh delvh changed the title Those have read permission of pull request should be assignable Users with read permission of pull requests can be assigned too Feb 24, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 24, 2024
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 24, 2024
@lunny lunny enabled auto-merge (squash) February 24, 2024 13:49
@lunny lunny merged commit 98ab944 into go-gitea:main Feb 24, 2024
26 checks passed
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Feb 24, 2024
@lunny @GiteaBot
Users with read permission of pull requests can be assigned too (go…
639bec5 
…-gitea#27263)

This PR will also keep the consistent between list assigned users and
check assigned users.
@GiteaBot GiteaBot mentioned this pull request Feb 24, 2024
Merged
@GiteaBot GiteaBot added backport/done All backports for this PR have been created and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Feb 24, 2024
delvh pushed a commit that referenced this pull request Feb 24, 2024
@GiteaBot @lunny
Users with read permission of pull requests can be assigned too (#2…
f98a1b8 
…7263) (#29372)

Backport #27263 by @lunny

This PR will also keep the consistent between list assigned users and
check assigned users.

Co-authored-by: Lunny Xiao <[email protected]>
@lunny lunny deleted the lunny/pr_read_be_assigneed branch February 25, 2024 04:10
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@delvh delvh delvh approved these changes

@denyskon denyskon denyskon approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/v1.21 This PR should be backported to Gitea 1.21 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/bug type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.
4 participants
@lunny @denyskon @delvh @GiteaBot