Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Differentiate between push and pull mirror sync in progress #27390

Merged
merged 4 commits into from
Oct 2, 2023
Merged

Differentiate between push and pull mirror sync in progress #27390

merged 4 commits into from
Oct 2, 2023

Conversation

delvh
Copy link
Member

@delvh delvh commented Oct 2, 2023 •
edited
Loading

Previously, if you had both a push and a pull mirror, the message did not clarify if you've accidentally synchronized the wrong one.
Additionally fixed two typos that were encountered while debugging.

Screenshots

grafik
grafik

@delvh
Differentiate between push and pull mirror sync in progress
5bac3d6 
Previously, if you had both a push and a pull mirror, the message did
not clarify if you've accidentally synchronized the wrong one.
Additionally fix two typos that were encountered while debugging.
@delvh delvh added type/enhancement An improvement of existing functionality topic/ui-interaction Change the process how users use Gitea instead of the visual appearance labels Oct 2, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 2, 2023
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 2, 2023
@delvh
Copy link
Member Author

delvh commented Oct 2, 2023

Note: I'm not too happy about the text wording but couldn't think of anything better.
If anyone has suggestions, let me know.

delvh
delvh commented Oct 2, 2023
View reviewed changes
options/locale/locale_en-US.ini Outdated Show resolved Hide resolved
@lunny lunny added this to the 1.22.0 milestone Oct 2, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 2, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 2, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Oct 2, 2023
@lunny lunny enabled auto-merge (squash) October 2, 2023 13:15
@lunny lunny merged commit e709bc1 into go-gitea:main Oct 2, 2023
25 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Oct 2, 2023
@delvh delvh deleted the better-synchronization-text branch October 19, 2023 20:34
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jan 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@puni9869 puni9869 puni9869 approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. topic/ui-interaction Change the process how users use Gitea instead of the visual appearance type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.
4 participants
@delvh @lunny @puni9869 @GiteaBot