Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor the function RemoveOrgUser #27582

Merged
merged 5 commits into from
Nov 3, 2023
Merged

Refactor the function RemoveOrgUser #27582

merged 5 commits into from
Nov 3, 2023

Conversation

lunny
Copy link
Member

@lunny lunny commented Oct 11, 2023 •
edited
Loading

This PR is a small refactor to merge removeOrgUser into RemoveOrgUser.

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Oct 11, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 11, 2023
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 11, 2023
@github-actions github-actions bot added the modifies/api This PR adds API routes or modifies them label Oct 11, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 11, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 20, 2023
@pull-request-size pull-request-size bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 20, 2023
@github-actions github-actions bot removed the modifies/api This PR adds API routes or modifies them label Oct 20, 2023
puni9869
puni9869 reviewed Oct 24, 2023
View reviewed changes
models/org.go Outdated Show resolved Hide resolved
@puni9869
Copy link
Member

puni9869 commented Oct 24, 2023 •
edited
Loading

Pr is missing one line description. Could you please add that too.
Unit test is failing.

@pull-request-size pull-request-size bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 3, 2023
@lunny lunny added this to the 1.22.0 milestone Nov 3, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Nov 3, 2023
@lunny lunny enabled auto-merge (squash) November 3, 2023 13:47
@lunny lunny merged commit d1dc9cb into go-gitea:main Nov 3, 2023
25 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Nov 3, 2023
@lunny lunny deleted the lunny/refactor_removeorg branch November 4, 2023 06:49
zjjhot added a commit to zjjhot/gitea that referenced this pull request Nov 6, 2023
@zjjhot
Merge remote-tracking branch 'upstream/main'
5780e1a 
* upstream/main:
  Fix edit topic UI (go-gitea#27925)
  Unify two factor check (go-gitea#27915)
  Revert go-gitea#27870 (go-gitea#27917)
  Fix JS NPE when viewing specific range of PR commits (go-gitea#27912)
  Install poetry dependencies with --no-root (go-gitea#27919)
  Show correct commit sha when viewing single commit diff (go-gitea#27916)
  Fix 500 when deleting a dismissed review (go-gitea#27903)
  Remove action runners on user deletion (go-gitea#27902)
  Remove SSH workaround (go-gitea#27893)
  Remove "tabindex" from some form buttons (go-gitea#27892)
  Refactor the function RemoveOrgUser (go-gitea#27582)
  Fix DownloadFunc when migrating releases (go-gitea#27887)
fuxiaohei pushed a commit to fuxiaohei/gitea that referenced this pull request Jan 17, 2024
@lunny @fuxiaohei
Refactor the function RemoveOrgUser (go-gitea#27582)
81e852d 
This PR is a small refactor to merge removeOrgUser into RemoveOrgUser.
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Feb 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@puni9869 puni9869 puni9869 approved these changes

@delvh delvh delvh approved these changes

@a1012112796 a1012112796 a1012112796 approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.
5 participants
@lunny @puni9869 @a1012112796 @delvh @GiteaBot