Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DownloadFunc when migrating releases (#27887) #27889

Merged
merged 1 commit into from
Nov 3, 2023
Merged

Fix DownloadFunc when migrating releases (#27887) #27889

merged 1 commit into from
Nov 3, 2023

Commits on Nov 3, 2023

  1. Fix DownloadFunc when migrating releases (go-gitea#27887) 

    We should not use `asset.ID` in DownloadFunc because DownloadFunc is a
closure.

https://github.com/go-gitea/gitea/blob/1bf5527eac6b947010c8faf408f6747de2a2384f/services/migrations/gitea_downloader.go#L284-L295

A similar bug when migrating from GitHub has been fixed in go-gitea#14703. This
PR fixes the bug when migrating from Gitea and GitLab.
    @Zettat123 @GiteaBot
    Zettat123 authored and GiteaBot committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    d936616 View commit details
    Browse the repository at this point in the history