Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix citation error when the file size is larger than 1024 bytes #27958

Merged
merged 2 commits into from
Nov 8, 2023

Conversation

yp05327
Copy link
Contributor

@yp05327 yp05327 commented Nov 8, 2023

Mentioned in: #27931 (comment)

Same to #25131, so use the same method to fix this problem.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 8, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 8, 2023
@yp05327
Copy link
Contributor Author

yp05327 commented Nov 8, 2023

I don't have enough time, but I think it is better to check all of them later.
image

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 8, 2023
@lunny
Copy link
Member

lunny commented Nov 8, 2023

Maybe we need to have a max limitation for these file.

@yp05327
Copy link
Contributor Author

yp05327 commented Nov 8, 2023

The max limitation is setting.UI.MaxDisplayFileSize which is 8MB as default.

yp05327 added a commit to yp05327/gitea that referenced this pull request Nov 8, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 8, 2023
@lunny lunny added type/bug type/enhancement An improvement of existing functionality reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. and removed type/bug labels Nov 8, 2023
@lunny lunny added this to the 1.22.0 milestone Nov 8, 2023
@lunny lunny enabled auto-merge (squash) November 8, 2023 06:01
@lunny lunny merged commit f48a863 into go-gitea:main Nov 8, 2023
25 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Nov 8, 2023
zjjhot added a commit to zjjhot/gitea that referenced this pull request Nov 8, 2023
* giteaofficial/main:
  Fix citation error when the file size is larger than 1024 bytes (go-gitea#27958)
  Use flex-container on user dashboard (go-gitea#27956)
  Document REACTION_MAX_USER_NUM setting option (go-gitea#27954)
  Add word-break to repo description in home page (go-gitea#27924)
  Remove go versions from .golangci.yml (go-gitea#27953)
  Fix the overflow style for "Hide all checks" (go-gitea#27932)
  Fix rendering assignee changed comments without assignee (go-gitea#27927)
  Add word break to release title (go-gitea#27942)
@silverwind silverwind added the backport/v1.21 This PR should be backported to Gitea 1.21 label Nov 8, 2023
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Nov 8, 2023
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label Nov 8, 2023
silverwind pushed a commit that referenced this pull request Nov 8, 2023
…) (#27965)

Backport #27958 by @yp05327

Mentioned in:
#27931 (comment)

Same to #25131, so use the same method to fix this problem.

Co-authored-by: yp05327 <[email protected]>
@yp05327 yp05327 deleted the fix-citation-js-error branch November 9, 2023 01:46
lunny pushed a commit that referenced this pull request Dec 6, 2023
Fix #28264

`DataAsync()` will be called twice.
Caused by #27958.
I'm sorry, I didn't completely remove all unnecessary codes.
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Dec 6, 2023
…#28314)

Fix go-gitea#28264

`DataAsync()` will be called twice.
Caused by go-gitea#27958.
I'm sorry, I didn't completely remove all unnecessary codes.
lunny pushed a commit that referenced this pull request Dec 6, 2023
…28369)

Backport #28314 by @yp05327

Fix #28264

`DataAsync()` will be called twice.
Caused by #27958.
I'm sorry, I didn't completely remove all unnecessary codes.

Co-authored-by: yp05327 <[email protected]>
fuxiaohei pushed a commit to fuxiaohei/gitea that referenced this pull request Jan 17, 2024
fuxiaohei pushed a commit to fuxiaohei/gitea that referenced this pull request Jan 17, 2024
…#28314)

Fix go-gitea#28264

`DataAsync()` will be called twice.
Caused by go-gitea#27958.
I'm sorry, I didn't completely remove all unnecessary codes.
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Feb 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created backport/v1.21 This PR should be backported to Gitea 1.21 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants