Prevent multiple codecomments to be submitted #28139
Conversation
- Utilize the existing `is-loading` class to prevent the submit code from running twice or more. - The `is-loading` class gives us a nice loading indicator when added to the form. - Resolves https://codeberg.org/forgejo/forgejo/issues/1476 (cherry picked from commit 85048c96608004988f57a57358c9cda91f095e23)
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/XS
| if ($form.hasClass('is-loading')) return; | ||
| $form.addClass('is-loading'); |
There was a problem hiding this comment.
Yes and no.
That class exists but is used for content that has not yet been loaded, not to click buttons only once.
There is a class that ensures buttons/forms are only submitted once.
I think it is form-fetch-action for forms or link-action for buttons/links.
Please use the correct class instead.
There was a problem hiding this comment.
The form-fetch-action uses this https://github.com/go-gitea/gitea/blob/main/web_src/js/features/common-global.js#L114-L116 and we cannot use form-fetch-action because the code comments has custom javascript code, which is initRepoDiffConversationForm.
Am I missing something?
There was a problem hiding this comment.
Okay, as @wxiaoguang pointed out in #28143, is-loading seems to be correct.
Sorry for that.
Anyway, #28143 does look better to me at the moment as it does not deadlock itself.
GiteaBot
added
lgtm/blocked
|
Which unimplemented edge cases do you see? |
|
-> #28143 At least 2 bugs here:
|
|
replaced by #28143 |
is-loadingclass to prevent the submit code from running twice or more.is-loadingclass gives us a nice loading indicator when added to the form.(cherry picked from commit 85048c96608004988f57a57358c9cda91f095e23)