Add download URL for executable files #28260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Consider executable files as a valid case when returning a downloadURL for them. They are just regular files with the difference being the executable permission bit being set. - Not integration testing as it's not possible without adding adjusting the existing repositories to have a executable file. - Resolves https://codeberg.org/forgejo/forgejo/issues/1825 (cherry picked from commit 84b59adafc33e4d636f2f79c766e770c738efe6a)
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/XS
delvh
reviewed
Nov 28, 2023
| @@ -219,7 +219,7 @@ func GetContents(ctx context.Context, repo *repo_model.Repository, treePath, ref | |||
| } | |||
| } | |||
| // Handle links | |||
| if entry.IsRegular() || entry.IsLink() { | |||
| if entry.IsRegular() || entry.IsLink() || entry.IsExecutable() { | |||
There was a problem hiding this comment.
How are directories stored in git?
As 755?
If yes, then is it reported as executable too?
There was a problem hiding this comment.
Since there is no response from author, I would like to try to answer it .... I think it is right, because the entry mode is determined by separate constants (not by bit masks):
wxiaoguang
approved these changes
Mar 6, 2024
GiteaBot
added
lgtm/need 1
lunny
approved these changes
Mar 6, 2024
GiteaBot
added
lgtm/done
silverwind
added a commit
to silverwind/gitea
that referenced
this pull request
Mar 6, 2024
* origin/main: (29 commits) Tweak actions color and borders (go-gitea#29640) Add download URL for executable files (go-gitea#28260) Move all login and account creation page labels to be above inputs (go-gitea#29432) Avoid issue info panic (go-gitea#29625) Cache repository default branch commit status to reduce query on commit status table (go-gitea#29444) Avoid unexpected panic in graceful manager (go-gitea#29629) Add a link for the recently pushed branch notification (go-gitea#29627) Fix wrong header of org project view page (go-gitea#29626) Detect broken git hooks (go-gitea#29494) Sync branches to DB immediately when handle git hook calling (go-gitea#29493) Fix wrong line number in code search result (go-gitea#29260) Make wiki default branch name changable (go-gitea#29603) A small refactor for agit implementation (go-gitea#29614) Update Twitter Logo (go-gitea#29621) Fix 500 error when adding PR comment (go-gitea#29622) Run editorconfig-checker on `locale_en-US.ini` (go-gitea#29608) bump protobuf module (go-gitea#29617) Add ac claim for old docker/build-push-action@v3 / current buildx gha cache (go-gitea#29584) Skip email domain check when admins edit user emails (go-gitea#29609) Improve natural sort (go-gitea#29611) ...
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Mar 7, 2024
* giteaofficial/main: Use strict protocol check when redirect (go-gitea#29642) Update various logos and unify their filenames (go-gitea#29637) Tweak actions color and borders (go-gitea#29640) Add download URL for executable files (go-gitea#28260) Move all login and account creation page labels to be above inputs (go-gitea#29432) Avoid issue info panic (go-gitea#29625) Cache repository default branch commit status to reduce query on commit status table (go-gitea#29444) Avoid unexpected panic in graceful manager (go-gitea#29629) Add a link for the recently pushed branch notification (go-gitea#29627) Fix wrong header of org project view page (go-gitea#29626) Detect broken git hooks (go-gitea#29494) Sync branches to DB immediately when handle git hook calling (go-gitea#29493) Fix wrong line number in code search result (go-gitea#29260) Make wiki default branch name changable (go-gitea#29603) A small refactor for agit implementation (go-gitea#29614) Update Twitter Logo (go-gitea#29621) Fix 500 error when adding PR comment (go-gitea#29622)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit 84b59adafc33e4d636f2f79c766e770c738efe6a)