Show in Web UI if file is vendored and generated #28620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/M
|
There is a similar logic on the compare page. Maybe the template can be shared. |
wxiaoguang
reviewed
Dec 28, 2023
wxiaoguang
reviewed
Dec 28, 2023
The code is here and is part of a larger function. I don't think it makes much sense to introduce a new service function for this few simple lines. For the template, it should look different as they are different usecases. |
delvh
approved these changes
Jan 9, 2024
GiteaBot
added
lgtm/need 1
denyskon
added
topic/repo
denyskon
approved these changes
Jan 21, 2024
GiteaBot
added
lgtm/done
Co-authored-by: delvh <[email protected]>
pull-request-size
bot
added
size/S
denyskon
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Jan 25, 2024
* giteaofficial/main: [skip ci] Updated translations via Crowdin Show in Web UI if file is vendored and generated (go-gitea#28620) Don't reload timeline page when (un)resolving or replying conversation (go-gitea#28654) Allow to sync tags from admin dashboard (go-gitea#28045) Don't run push mirrors for archived repos (go-gitea#27140) Only migrate the first 255 chars of a Github issue title (go-gitea#28902) Fix hardcoded GitHub icon used as migrated release avatar (go-gitea#28910) [skip ci] Updated translations via Crowdin Update go dependencies and fix go-git (go-gitea#28893)
henrygoodman
pushed a commit
to henrygoodman/gitea
that referenced
this pull request
Jan 31, 2024
This simple shows in the Web UI is a file is vendored and/or generated.   --------- Co-authored-by: delvh <[email protected]> Co-authored-by: Lunny Xiao <[email protected]>
silverwind
pushed a commit
to silverwind/gitea
that referenced
this pull request
Feb 20, 2024
This simple shows in the Web UI is a file is vendored and/or generated.   --------- Co-authored-by: delvh <[email protected]> Co-authored-by: Lunny Xiao <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simple shows in the Web UI is a file is vendored and/or generated.