add close issue on move flag to board and add a cron to remove closed issues from board with that flag #28800
Conversation
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/L
|
Looks like these are too hardcoded. Maybe we need a whole design before sending PRs. Or maybe it can be implemented from actions if Gitea supported board events. |
|
the lifecycle of an issue is complete after it is closed, at least in our org, and we really needed this feature, so closed issues doesnt clutter our kanbans, found this(hardcoded) as the fastest way to get this pr done and deployed
should i try adding board events then to achieve this ? (or is it already in plan ?), i am happy to update code to make it mergeable so we can get this feature to everyone |
I think yes, we need to add board events first. |
I think we could land this PR before board events. |
| Default bool `xorm:"NOT NULL DEFAULT false"` // issues not assigned to a specific board will be assigned to this board | ||
| Sorting int8 `xorm:"NOT NULL DEFAULT 0"` | ||
| Color string `xorm:"VARCHAR(7)"` | ||
| CloseIssueOnMove bool `xorm:"DEFAULT false"` |
There was a problem hiding this comment.
as there are new fields added to a model struct, could you add a migration to add this?
There was a problem hiding this comment.
as there are new fields added to a model struct, could you add a migration to add this?
on a sidenote, regarding migration, i actually broke our prod with a migration(not this pr), it worked after i removed the migration, is there some doc about how to do migration correctly in gitea ?
| @@ -747,5 +749,19 @@ func MoveIssues(ctx *context.Context) { | |||
| return | |||
| } | |||
|
|
|||
| if board.CloseIssueOnMove { | |||
There was a problem hiding this comment.
to remove the if nesting, you could do something like
if !board.CloseIssueOnMove {
ctx.JSONOK()
return
}
//... board close logic
| @@ -696,5 +699,19 @@ func MoveIssues(ctx *context.Context) { | |||
| return | |||
| } | |||
|
|
|||
| if board.CloseIssueOnMove { | |||
| return errors.New("failed getting issue") | ||
| } | ||
|
|
||
| if err := ChangeStatus(ctx, issue, ctx.Doer, "", true); err != nil { |
There was a problem hiding this comment.
you could also remove if nesting here by checking if err is nil and moving the status change function call prior to the if, and then return in the if, and after the if, continue with the remaining logic.
| ) | ||
|
|
||
| // Cleanup removes closed issues from project board with close on move flag set to true | ||
| func CleanupProjectIssues(taskCtx context.Context, olderThan time.Duration) error { |
There was a problem hiding this comment.
while this function would work with smaller instances, the resource consumption with larger ones can grow significantly with the several selects and no limits/pagination.
Could this logic be done with SQL itself, a join on projects where they have closeonmove, with issues that belong to a board that are closed? Then a separate statement to rm the issue from the project? Then in the rm statement(s) you could batch rm the rows from the DB?
|
@iminfinity Thank you for your contributions. But I think it's also hardcode. I think this PR should also be replaced by #30205 or changed after that PR merged as one event implementation. |
add close issue on move flag to board which closes the moved issue
and add a cron to remove closed issues from board with that flag weekly
currently when a issue is added to project, it is never removed automatically, we dont want to spend time on removing closed issues from column
implements feature 1 of issue #27081
PR sponsored by Obmondo.com
Screen.Recording.-.Jan.12.2024.mp4