New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide code links on release page if user cannot read code (#29064) #29066

Merged

lunny merged 1 commit into go-gitea:release/v1.21 from GiteaBot:backport-29064-v1.21

Feb 6, 2024

+5 −24

Commits on Feb 6, 2024

Hide code links on release page if user cannot read code (go-gitea#29064

)

On the release list page, if the user doesn't have the permission to
read code, the code links will lead to 404 pages or api errors:

<img width="1297" alt="image"
src="https://github.com/go-gitea/gitea/assets/9418365/a74fbc63-6dd6-43c6-853c-28acdbfdcb4e">


After this PR:

<img width="1297" alt="image"
src="https://github.com/go-gitea/gitea/assets/9418365/a626373d-c2df-40a9-8fed-1b12ff6bc56f">

And this PR also removed some dead code. After go-gitea#23465, the tag list page
has an independent template, and all `IsTag` in the release list
template are always false.

wolfogre authored and GiteaBot committed Feb 6, 2024