Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use defaults browserslist #29098

Merged
merged 2 commits into from
Feb 8, 2024
Merged

Use defaults browserslist #29098

merged 2 commits into from
Feb 8, 2024

Conversation

silverwind
Copy link
Member

IE usage has dropped enough to not be included in the defaults browserslist anymore as per https://browsersl.ist/#q=defaults, so we can use the defaults now.

IE usage has dropped enough to not be included in the defaults
browserslist anymore as per https://browsersl.ist/#q=defaults, so we can
use the defaults now.
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 8, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 8, 2024
@silverwind silverwind added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Feb 8, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 8, 2024
@silverwind
Copy link
Member Author

silverwind commented Feb 8, 2024

BTW that website highlights a issue "Less than 80% coverage in China regions" with "defaults" and suggests a "fix" to ">0.3%, defaults".

https://browsersl.ist/#q=defaults%0A - Global Audience coverage: 88.8 %
https://browsersl.ist/#q=%3E0.3%25%2C+defaults - Global Audience coverage: 90.3 %

I don't think it's worth diverging from defaults, I would expect browserslist to instead improve their defaults in the future. Also I think it's less of a problem for gitea as it's users are more likely to have an updated browser than the global average.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 8, 2024
@silverwind silverwind added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 8, 2024
@silverwind silverwind enabled auto-merge (squash) February 8, 2024 13:45
@silverwind silverwind merged commit ce9978b into go-gitea:main Feb 8, 2024
25 checks passed
@GiteaBot GiteaBot added this to the 1.22.0 milestone Feb 8, 2024
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 8, 2024
silverwind added a commit to silverwind/gitea that referenced this pull request Feb 20, 2024
IE usage has dropped enough to not be included in the defaults
browserslist anymore as per https://browsersl.ist/#q=defaults, so we can
use the defaults now.
6543 pushed a commit to 6543-forks/gitea that referenced this pull request Feb 26, 2024
IE usage has dropped enough to not be included in the defaults
browserslist anymore as per https://browsersl.ist/#q=defaults, so we can
use the defaults now.

(cherry picked from commit ce9978b)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants