Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont load Review if Comment is CommentTypeReviewRequest (#28551) #29160

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

6543
Copy link
Member

@6543 6543 commented Feb 13, 2024

Backport #28551

RequestReview get deleted on review.
So we don't have to try to load them on comments.

RequestReview get deleted on review.
So we don't have to try to load them on comments.

broken out go-gitea#28544
@6543 6543 added the type/bug label Feb 13, 2024
@6543 6543 added this to the 1.21.6 milestone Feb 13, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 13, 2024
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 13, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 13, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 13, 2024
@silverwind silverwind merged commit 0ac3186 into go-gitea:release/v1.21 Feb 13, 2024
26 checks passed
@6543 6543 deleted the backport_28551 branch February 14, 2024 21:57
Copy link

Automatically locked because of our CONTRIBUTING guidelines

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants