Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip email domain check when admin users adds user manually (#29522) #29605

Closed
wants to merge 3 commits into from
Closed

Skip email domain check when admin users adds user manually (#29522) #29605

wants to merge 3 commits into from

Conversation

Zettat123
Copy link
Contributor

@Zettat123 Zettat123 commented Mar 5, 2024 •
edited
Loading

Backport #29522
Fix #27457

Administrators should be able to manually create any user even if the user's email address is not in EMAIL_DOMAIN_ALLOWLIST.

Blocked by #29522 (comment)

@Zettat123
Skip email domain check when admin users adds user manually (go-gitea…
421a76f 
…#29522)

Fix go-gitea#27457

Administrators should be able to manually create any user even if the
user's email address is not in `EMAIL_DOMAIN_ALLOWLIST`.
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 5, 2024
@GiteaBot GiteaBot added this to the 1.21.8 milestone Mar 5, 2024
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 5, 2024
@github-actions github-actions bot added the modifies/api This PR adds API routes or modifies them label Mar 5, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 5, 2024
@Zettat123 Zettat123 marked this pull request as draft March 5, 2024 07:18
@yp05327
Copy link
Contributor

yp05327 commented Mar 6, 2024

Maybe a warning is necessary, as the admin who adds user and the admin who sets EMAIL_DOMAIN_ALLOWLIST may not be same. Showing a warning can notify the admin who adds user to avoid unexpected problems.

@Zettat123
Copy link
Contributor Author

Close by #29522 (comment)

@Zettat123 Zettat123 closed this Mar 8, 2024
@GiteaBot GiteaBot removed this from the 1.21.8 milestone Mar 8, 2024
@Zettat123 Zettat123 mentioned this pull request Mar 8, 2024
Merged
@yp05327 yp05327 mentioned this pull request Mar 8, 2024
Closed
lunny pushed a commit that referenced this pull request Mar 11, 2024
@Zettat123
Add a warning for disallowed email domains (#29658)
4129e0e 
Resolve #29660

Follow #29522 and #29609

Add a warning for disallowed email domains when admins manually add/edit
users.

Thanks @yp05327 for the
[comment](#29605 (comment))

![image](https://github.com/go-gitea/gitea/assets/15528715/6737b221-a3a2-4180-9ef8-b846c10f96e0)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/need 1 This PR needs approval from one additional maintainer to be merged. modifies/api This PR adds API routes or modifies them size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Zettat123 @yp05327 @lunny @GiteaBot @silverwind