Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump python version to 3.12 in dev container #29670

Merged

Conversation

yp05327
Copy link
Contributor

@yp05327 yp05327 commented Mar 8, 2024

image

The default version is 3.9.2, which is not supported by poetry.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 8, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 8, 2024
@yp05327 yp05327 added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Mar 8, 2024
@silverwind
Copy link
Member

Bump it to 3.12 if possible, that's what we use on CI.

@silverwind silverwind changed the title bump python version to 3.10 in dev container bump python version to 3.12 in dev container Mar 8, 2024
Copy link
Member

@silverwind silverwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please test it.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 8, 2024
@yp05327
Copy link
Contributor Author

yp05327 commented Mar 8, 2024

Tested the build process and postCreateCommand. It works well.What others should I test?
image

ps: As I know, dev container image can be built and run by cli command(https://github.com/devcontainers/cli), so maybe it is possible to test it in ci.

@silverwind
Copy link
Member

Tested the build process and postCreateCommand. It works well.What others should I test?

All good, I was just worried 3.12 might not be available yet.

ps: As I know, dev container image can be built and run by cli command(https://github.com/devcontainers/cli), so maybe it is possible to test it in ci.

How fast does it build?

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 8, 2024
@yp05327
Copy link
Contributor Author

yp05327 commented Mar 8, 2024

How fast does it build?

I think this is based on the spec and the speed of the internet.
And it wouldn't be fast, as docker build is always slow IMO.

But we don't need to test it every time, only on the config changed, and that won't be too often.
Maybe we can consider it later, when it becomes important enough to do it.

@silverwind
Copy link
Member

silverwind commented Mar 8, 2024

Yeah, sounds plausible to run it only when the config changed via files-changed. If it's fast enough (I'd say sub 2 minutes), also add pyproject.toml, package.json and go.mod to dependencies.

@silverwind silverwind merged commit b253463 into go-gitea:main Mar 8, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.23.0 milestone Mar 8, 2024
@yp05327 yp05327 deleted the bump-python-version-in-devcontainer branch March 8, 2024 15:25
zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 8, 2024
* giteaofficial/main:
  Fix commit_status problem when testing (go-gitea#29672)
  Support pasting URLs over markdown text (go-gitea#29566)
  bump python version to 3.12 in dev container (go-gitea#29670)
@denyskon denyskon modified the milestones: 1.23.0, 1.22.0 Mar 8, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants