-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump python version to 3.12 in dev container #29670
bump python version to 3.12 in dev container #29670
Conversation
Bump it to 3.12 if possible, that's what we use on CI. |
Co-authored-by: silverwind <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please test it.
Tested the build process and postCreateCommand. It works well.What others should I test? ps: As I know, dev container image can be built and run by cli command(https://github.com/devcontainers/cli), so maybe it is possible to test it in ci. |
All good, I was just worried 3.12 might not be available yet.
How fast does it build? |
I think this is based on the spec and the speed of the internet. But we don't need to test it every time, only on the config changed, and that won't be too often. |
Yeah, sounds plausible to run it only when the config changed via |
* giteaofficial/main: Fix commit_status problem when testing (go-gitea#29672) Support pasting URLs over markdown text (go-gitea#29566) bump python version to 3.12 in dev container (go-gitea#29670)
The default version is 3.9.2, which is not supported by poetry.