-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support actions syntax tokens #29777
base: main
Are you sure you want to change the base?
Conversation
d7d33f7
to
1abbdbf
Compare
1abbdbf
to
cfaf745
Compare
full commands list is here: https://github.com/actions/toolkit/blob/main/docs/commands.md#problem-matchers |
I can help remove the emoji prefix if it's really bothering. I noticed that too, but I didn't have the motivation to resolve it. |
Please do. I would code this matcher to only work when |
https://gitea.com/gitea/act/pulls/97 And I'll update act_runner later. |
Remove emojis in command outputs; leave others since they don't matter. Help go-gitea/gitea#29777 Reviewed-on: https://gitea.com/gitea/act/pulls/97
Remove emojis in command outputs; leave others since they don't matter. Help go-gitea/gitea#29777 Reviewed-on: https://gitea.com/gitea/act/pulls/97
act_runner has now received the updates |
Those commands needs to be interpreted by act_runner/act. I would like that The actions/runner converts them into the alternative (aka azure devops notation) command syntax https://gitea.com/ChristopherHX/actions_runner/actions/runs/97
Both act and actions/runner supports the two different command syntaxes. Obviously I could tell my third party runner adapter to convert it back, not a big deal after all. |
Ok then we hide those completely on the UI. |
Adding a note for another thing I discovered in the renderer: Lines that match a certain regex with filename at the start are highlighted as error, but as seen below that regex of GitHub has a bug where it does not highlight column ranges. No idea how those error annotations look in the raw format, but I expect there to be some token that can be matched. |
The bug with line ranges is probably in this file https://github.com/actions/setup-go/blob/main/matchers.json
I'm not shure how it is possible to avoid replicating the line range bug without implementing builtin problem matchers on either UI or runner side. E.g. the Gitea Workflow could register it's own problem matcher, which matches for line ranges |
Interesting, I wouldn't have thought that it was BTW, I think the format |
TODO:
::add-matcher
and::remove-matcher
have any meaning to us##[error]
Also there seems to be some strange emoji-prefixed stuff which I think comes from either
act_runner
oract
, I wonder what to do with it because I think these are invalid with that💬
prefix.