Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support GITEA_I_AM_BEING_UNSAFE_RUNNING_AS_ROOT env #29788

Merged
merged 6 commits into from
Mar 14, 2024
Merged

Support GITEA_I_AM_BEING_UNSAFE_RUNNING_AS_ROOT env #29788

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
335b18d
chore: enable unsafeAllowRunAsRoot by env
wolfogre Mar 14, 2024
c684930
chore: patch
wolfogre Mar 14, 2024
a483b95
Merge branch 'main' into feature/run_gitea_as_root
GiteaBot Mar 14, 2024
a295fb1
Merge branch 'main' into feature/run_gitea_as_root
GiteaBot Mar 14, 2024
43bb748
Update modules/setting/setting.go
wolfogre Mar 14, 2024
d1a7b5c
Update setting.go
wxiaoguang Mar 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions modules/setting/setting.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import (

"code.gitea.io/gitea/modules/log"
"code.gitea.io/gitea/modules/user"
"code.gitea.io/gitea/modules/util"
)

// settings
Expand Down Expand Up @@ -158,9 +159,11 @@ func loadCommonSettingsFrom(cfg ConfigProvider) error {
func loadRunModeFrom(rootCfg ConfigProvider) {
rootSec := rootCfg.Section("")
RunUser = rootSec.Key("RUN_USER").MustString(user.CurrentUsername())

// The following is a purposefully undocumented option. Please do not run Gitea as root. It will only cause future headaches.
// Please don't use root as a bandaid to "fix" something that is broken, instead the broken thing should instead be fixed properly.
unsafeAllowRunAsRoot := ConfigSectionKeyBool(rootSec, "I_AM_BEING_UNSAFE_RUNNING_AS_ROOT")
unsafeAllowRunAsRoot = unsafeAllowRunAsRoot || util.OptionalBoolParse(os.Getenv("GITEA_I_AM_BEING_UNSAFE_RUNNING_AS_ROOT")).Value()
RunMode = os.Getenv("GITEA_RUN_MODE")
if RunMode == "" {
RunMode = rootSec.Key("RUN_MODE").MustString("prod")
Expand Down