Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid JS error on issue/pr list when logged out #29854

Merged
merged 6 commits into from
Mar 17, 2024
Merged

Avoid JS error on issue/pr list when logged out #29854

Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
85ef7c9
Avoid JS error when logged out
silverwind Mar 16, 2024
d075b5d
add and use window.config.isSignedIn
silverwind Mar 17, 2024
f5dcea1
Update web_src/js/features/repo-issue-list.js
silverwind Mar 17, 2024
f836874
rm
silverwind Mar 17, 2024
f315e44
format
silverwind Mar 17, 2024
68db4a8
Merge branch 'main' into averr
GiteaBot Mar 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion web_src/js/features/repo-issue-list.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import {DELETE, POST} from '../modules/fetch.js';
function initRepoIssueListCheckboxes() {
const issueSelectAll = document.querySelector('.issue-checkbox-all');
const issueCheckboxes = document.querySelectorAll('.issue-checkbox');
if(!issueSelectAll) return;

const syncIssueSelectionState = () => {
const checkedCheckboxes = Array.from(issueCheckboxes).filter((el) => el.checked);
Expand Down Expand Up @@ -40,7 +41,7 @@ function initRepoIssueListCheckboxes() {
el.addEventListener('change', syncIssueSelectionState);
}

issueSelectAll.addEventListener('change', () => {
issueSelectAll?.addEventListener('change', () => {
silverwind marked this conversation as resolved.
Show resolved Hide resolved
for (const el of issueCheckboxes) {
el.checked = issueSelectAll.checked;
}
Expand Down
Loading