Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix manual merge form and 404 page templates #30000

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Mar 22, 2024

Partially backport #29985, fix some template errors.

The manual-merge form:

image

The 404 page:

image

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 22, 2024
@GiteaBot GiteaBot added this to the 1.21.10 milestone Mar 22, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 22, 2024
@github-actions github-actions bot added the modifies/templates This PR modifies the template files label Mar 22, 2024
@pull-request-size pull-request-size bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 22, 2024
@wolfogre
Copy link
Member

Off-topic: 30000 achievement unlocked!

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 22, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 22, 2024
@wxiaoguang wxiaoguang merged commit 24c66c5 into go-gitea:release/v1.21 Mar 22, 2024
27 checks passed
@wxiaoguang wxiaoguang deleted the backport-tmpl-fix branch March 22, 2024 11:42
TKaxv-7S added a commit to TKaxv-7S/gitea that referenced this pull request Apr 10, 2024
v1.21.10
* BUGFIXES
  * Fix Add/Remove WIP on pull request title failure (go-gitea#29999) (go-gitea#30066)
  * Fix misuse of `TxContext` (go-gitea#30061) (go-gitea#30062)
  * Respect DEFAULT_ORG_MEMBER_VISIBLE setting when adding creator to org (go-gitea#30013) (go-gitea#30035)
  * Escape paths for find file correctly (go-gitea#30026) (go-gitea#30031)
  * Remove duplicate option in admin screen and now-unused translation keys (go-gitea#28492) (go-gitea#30024)
  * Fix manual merge form and 404 page templates (go-gitea#30000)

# gpg: Signature made Tue, Mar 26, 2024  7:48:36 AM
# gpg:                using EDDSA key 8722B61D72341082553B201CB8BE6D610E61C862
# gpg: Can't check signature: No public key
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jun 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/templates This PR modifies the template files size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants