Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change commit page signature indication to icon only #30221

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Change commit page signature indication to icon only #30221

wants to merge 4 commits into from

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Apr 1, 2024 •
edited
Loading

Part of #29641.

Commit page header is now always uncolored and the signature status is shown by a new icon:
Screenshot 2024-04-01 at 02 10 15

Screenshot 2024-04-01 at 02 12 46 Screenshot 2024-04-01 at 01 55 43

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 1, 2024
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 1, 2024
silverwind
silverwind commented Apr 1, 2024
View reviewed changes
templates/shared/verifyicon.tmpl
{{if .Verification.Reason}}
{{$text = (ctx.Locale.Tr .Verification.Reason)}}
{{else}}
{{$text = (ctx.Locale.Tr "sig_failed")}}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this condition can be reached. At least it wasn't necessary before, so maybe can remove.

@lunny
Copy link
Member

lunny commented Apr 1, 2024

image

@silverwind
Copy link
Member Author

image

Should be fixed with 5965d4a, no idea why it didn't error for me 😆

@silverwind silverwind mentioned this pull request Apr 1, 2024
Merged
@silverwind silverwind marked this pull request as draft April 1, 2024 17:46
@silverwind
Copy link
Member Author

WIP because I need to double-check that the logic is same as previous, it's quite convoluted.

@silverwind silverwind mentioned this pull request May 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. modifies/js modifies/templates This PR modifies the template files modifies/translation size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@silverwind @lunny @GiteaBot