Add e2e install testing #30241
Closed
Add e2e install testing #30241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/M
github-actions
bot
added
modifies/go
|
Keep note that the e2e tests are currently not totally reliable. It seems to fail pretty often though the tests pass as "flaky", like in the current run from this branch: So if you can figure out what that problem is, we could maybe disable this "flaky" mechanism. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request expands e2e testing to include the install page.
#21490 is the parent issue, and these changes should hopefully catch future regressions of that nature. From what I can tell the actual error occurred during page rendering.
The ability to actually perform an install during e2e testing is limited at the moment. I've added more details inside the relevant test, but this is my first contribution and so I felt it might be helpful to get some feedback on the right approach to expanding the coverage.