Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up log messages (#30313) #30318

Merged
merged 1 commit into from
Apr 7, 2024

Conversation

GiteaBot
Copy link
Contributor

@GiteaBot GiteaBot commented Apr 7, 2024

Backport #30313 by wxiaoguang

log.Xxx("%v") is not ideal, this PR adds necessary context messages. Remove some unnecessary logs.

`log.Xxx("%v")` is not ideal, this PR adds necessary context messages.
Remove some unnecessary logs.

Co-authored-by: Giteabot <[email protected]>
@GiteaBot GiteaBot added modifies/api This PR adds API routes or modifies them modifies/cli PR changes something on the CLI, i.e. gitea doctor or gitea admin modifies/go Pull requests that update Go code type/refactoring Existing code has been cleaned up. There should be no new functionality. labels Apr 7, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 7, 2024
@GiteaBot GiteaBot added this to the 1.22.0 milestone Apr 7, 2024
@GiteaBot GiteaBot requested review from delvh and lunny April 7, 2024 11:17
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 7, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 7, 2024
@wxiaoguang wxiaoguang enabled auto-merge (squash) April 7, 2024 11:18
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 7, 2024
@wxiaoguang wxiaoguang merged commit 5a6f735 into go-gitea:release/v1.22 Apr 7, 2024
26 checks passed
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jul 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them modifies/cli PR changes something on the CLI, i.e. gitea doctor or gitea admin modifies/go Pull requests that update Go code size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants