Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove fomantic menu module #30325

Merged
merged 7 commits into from
Apr 14, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
186 changes: 1 addition & 185 deletions web_src/css/base.css
Original file line number Diff line number Diff line change
Expand Up @@ -319,70 +319,13 @@ a.label,
background-color: var(--color-label-bg);
}

.ui.menu {
display: flex;
}

.ui.menu,
.ui.vertical.menu {
background: var(--color-menu);
border-color: var(--color-secondary);
box-shadow: none;
}

.ui.menu .item {
color: var(--color-text);
user-select: auto;
line-height: var(--line-height-default); /* fomantic uses "1" which causes overflow problems because "1" doesn't consider the descent part */
}

.ui.menu .item > .svg {
margin-right: 0.35em;
}

.ui.menu .dropdown.item:hover,
.ui.menu a.item:hover,
.ui.menu details.item summary:hover {
color: var(--color-text);
background: var(--color-hover);
}

.ui.menu .active.item,
.ui.menu .active.item:hover,
.ui.vertical.menu .active.item,
.ui.vertical.menu .active.item:hover {
color: var(--color-text);
background: var(--color-active);
}

.ui.menu a.item:active {
color: var(--color-text);
background: none;
}

.ui.ui.menu .item.disabled {
color: var(--color-text-light-3);
}

.ui.menu .item::before, .ui.vertical.menu .item::before {
background: var(--color-secondary);
}

/* sub menu of vertical menu */
.ui.vertical.menu .item .menu .item {
color: var(--color-text-light-2);
text-indent: 16px;
}

.ui.vertical.menu .item .menu .item:hover,
.ui.vertical.menu .item .menu a.item:hover {
color: var(--color-text-light-1);
}

.ui.vertical.menu .item .menu .active.item {
color: var(--color-text);
}

/* slightly more contrast for filters on issue list */
.ui.ui.menu .dropdown.item.disabled {
color: var(--color-text-light-2);
Expand Down Expand Up @@ -441,11 +384,6 @@ a.label,
background: var(--color-hover);
}

.ui.menu .ui.dropdown .menu > .selected.item {
color: var(--color-text) !important;
background: var(--color-hover) !important;
}

.ui.dropdown .menu > .message:not(.ui) {
color: var(--color-text-light-2);
}
Expand All @@ -462,58 +400,6 @@ a.label,
color: var(--color-text-light-2);
}

/* replace item margin on secondary menu items with gap and remove both the
negative margins on the menu as well as margin on the items */
.ui.secondary.menu {
margin-left: 0;
margin-right: 0;
gap: .35714286em;
}
.ui.secondary.menu .item {
margin-left: 0;
margin-right: 0;
}

.ui.secondary.menu .dropdown.item:hover,
.ui.secondary.menu a.item:hover {
color: var(--color-text);
background: var(--color-hover);
}

.ui.secondary.menu .active.item,
.ui.secondary.menu .active.item:hover {
color: var(--color-text);
background: var(--color-active);
}

.ui.secondary.menu.tight .item {
padding-left: 0.85714286em;
padding-right: 0.85714286em;
}

/* remove the menu clearfix so that it won't add undesired gaps when using "gap" */
.ui.menu::after {
content: normal;
}

.ui.menu .dropdown.item .menu {
background: var(--color-body);
}

.ui.menu .ui.dropdown .menu > .item {
color: var(--color-text) !important;
}

.ui.menu .ui.dropdown .menu > .item:hover {
color: var(--color-text) !important;
background: var(--color-hover) !important;
}

.ui.menu .ui.dropdown .menu > .active.item {
color: var(--color-text) !important;
background: var(--color-active) !important;
}

.ui.form textarea:not([rows]) {
height: var(--min-height-textarea); /* override fomantic default 12em */
min-height: var(--min-height-textarea); /* override fomantic default 8em */
Expand Down Expand Up @@ -606,11 +492,6 @@ img.ui.avatar,
margin-top: calc(var(--page-spacing) - 1rem);
}

.ui.pagination.menu .active.item {
color: var(--color-text);
background: var(--color-active);
}

.ui.form .fields.error .field textarea,
.ui.form .fields.error .field select,
.ui.form .fields.error .field input:not([type]),
Expand Down Expand Up @@ -786,7 +667,7 @@ input:-webkit-autofill:active,
font-weight: var(--font-weight-normal);
}

/* replace fomantic popover box shadows */
/* popover box shadows */
.ui.dropdown .menu,
.ui.upward.dropdown > .menu,
.ui.menu .dropdown.item .menu,
Expand All @@ -804,22 +685,6 @@ input:-webkit-autofill:active,
background: var(--color-overlay-backdrop);
}

/* Override semantic selector '.ui.menu:not(.vertical) .item > .button' */
/* This fixes the commit graph button on the commits page */
/* modal svg icons, copied from fomantic except width and height */
/* center text in fomantic modal dialogs */
.ui .menu:not(.vertical) .item > .button.compact {
padding: 0.58928571em 1.125em;
}

.ui .menu:not(.vertical) .item > .button.small {
font-size: 0.92857143rem;
}

.ui.menu .ui.dropdown.item .menu .item {
width: 100%;
}

.ui.dropdown .menu > .header {
font-size: 0.8em;
}
Expand Down Expand Up @@ -1010,24 +875,6 @@ input:-webkit-autofill:active,
border-color: var(--color-gold) !important;
}

@media (max-width: 767.98px) {
.ui.pagination.menu .item:not(.active,.navigation),
.ui.pagination.menu .item.navigation span.navigation_label {
display: none;
}
}

.ui.pagination.menu.narrow .item {
padding-left: 8px;
padding-right: 8px;
min-width: 1em;
text-align: center;
}

.ui.pagination.menu.narrow .item .icon {
margin-right: 0;
}

.ui.floating.dropdown .overflow.menu .scrolling.menu.items {
border-radius: 0 !important;
box-shadow: none !important;
Expand Down Expand Up @@ -1149,11 +996,6 @@ overflow-menu .ui.label {
margin-top: 1px;
}

.ui.menu .item > .label {
background: var(--color-label-bg);
color: var(--color-label-text);
}

.lines-blame-btn {
padding: 0 0 0 5px;
display: flex;
Expand Down Expand Up @@ -1382,26 +1224,6 @@ table th[data-sortt-desc] .svg {
vertical-align: -0.15em;
}

.ui.tabular.menu {
border-color: var(--color-secondary);
}

.ui.tabular.menu .active.item,
.ui.tabular.menu .active.item:hover {
background: var(--color-body);
border-color: var(--color-secondary);
color: var(--color-text);
}

.ui.segment .ui.tabular.menu .active.item,
.ui.segment .ui.tabular.menu .active.item:hover {
background: var(--color-box-body);
}

.ui.secondary.pointing.menu {
border-color: var(--color-secondary);
}

.ui.tabular.menu .item,
.ui.secondary.pointing.menu .item {
padding: 11.55px 12px !important; /* match .dashboard-navbar in height */
Expand All @@ -1413,12 +1235,6 @@ table th[data-sortt-desc] .svg {
color: var(--color-text);
}

.ui.secondary.pointing.menu .active.item,
.ui.secondary.pointing.menu .active.item:hover,
.ui.secondary.pointing.menu .dropdown.item:hover {
color: var(--color-text-dark);
}

.ui.tabular.menu .active.item,
.ui.secondary.pointing.menu .active.item,
.resize-for-semibold::before {
Expand Down
1 change: 1 addition & 0 deletions web_src/css/index.css
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
@import "./modules/list.css";
@import "./modules/segment.css";
@import "./modules/grid.css";
@import "./modules/menu.css";
@import "./modules/message.css";
@import "./modules/table.css";
@import "./modules/card.css";
Expand Down
Loading