Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sanitize logs for mirror sync #3057

Merged
merged 2 commits into from
Dec 3, 2017
Merged

Sanitize logs for mirror sync #3057

merged 2 commits into from
Dec 3, 2017

Conversation

ethantkoenig
Copy link
Member

Fixes #3055. Do not display mirror remote addresses in logs or repository notices, since the remote addresses may contain passwords.

@codecov-io
Copy link

codecov-io commented Dec 2, 2017 •
edited
Loading

Codecov Report

Merging #3057 into master will increase coverage by <.01%.
The diff coverage is 8.1%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3057      +/-   ##
==========================================
+ Coverage   33.46%   33.46%   +<.01%     
==========================================
  Files         270      270              
  Lines       39534    39564      +30     
==========================================
+ Hits        13229    13240      +11     
- Misses      24420    24434      +14     
- Partials     1885     1890       +5
Impacted Files Coverage Δ
models/repo_mirror.go 3.2% <0%> (-0.57%) ⬇️
models/repo.go 38.15% <100%> (-0.11%) ⬇️
modules/indexer/repo.go 63.47% <0%> (+2.6%) ⬆️
models/repo_indexer.go 51.98% <0%> (+2.97%) ⬆️
modules/process/manager.go 81.15% <0%> (+4.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3163abe...6140459. Read the comment docs.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 2, 2017
@lunny lunny added this to the 1.4.0 milestone Dec 2, 2017
@lafriks
Copy link
Member

lafriks commented Dec 2, 2017

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 2, 2017
@lunny
Copy link
Member

lunny commented Dec 3, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 3, 2017
@lunny lunny merged commit a096477 into go-gitea:master Dec 3, 2017
@lafriks lafriks added type/enhancement An improvement of existing functionality topic/security Something leaks user information or is otherwise vulnerable. Should be fixed! backport/v1.3 and removed type/enhancement An improvement of existing functionality labels Dec 3, 2017
@lafriks
Copy link
Member

lafriks commented Dec 3, 2017

@ethantkoenig please backport

@ethantkoenig ethantkoenig mentioned this pull request Dec 3, 2017
Merged
@lafriks lafriks added the backport/done All backports for this PR have been created label Dec 4, 2017
@lafriks lafriks mentioned this pull request Dec 4, 2017
Merged
lafriks pushed a commit that referenced this pull request Dec 8, 2017
@ethantkoenig @lafriks
Sanitize logs for mirror sync (#3057, #3082) (#3078)
ec6718e 
* Sanitize logs for mirror sync

* Fix error message sanitiziation (#3082)
@ethantkoenig ethantkoenig deleted the fix/mirror_logs branch December 18, 2017 06:09
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/security Something leaks user information or is otherwise vulnerable. Should be fixed!
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.

Plaintext passwords in error.log
5 participants
@ethantkoenig @codecov-io @lafriks @lunny @tboerger