Fix border-radius of header+segment boxes #30667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/XS
silverwind
force-pushed
the
radius-segments
branch
from
a3ad0ea
to
b6eae40
Compare
delvh
approved these changes
Apr 23, 2024
GiteaBot
added
lgtm/need 1
|
I created #30673 to list almost all the possible UI border-radius problems after this PR. |
|
I imagine this PR likely fixes half of them. |
lunny
approved these changes
Apr 24, 2024
GiteaBot
added
lgtm/done
That PR just listed all problems which haven't been fixed by this PR. |
|
Ok, wouldn't have thought there'd be still so many. I will check them out later. |
silverwind
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
silverwind
added a commit
to pangliang/gitea
that referenced
this pull request
Apr 24, 2024
…low_dispatch_event * origin/main: (62 commits) Add test for go-gitea#30674 (go-gitea#30679) Fix border-radius of header+segment boxes (go-gitea#30667) Fix a panic bug when head repository deleting (go-gitea#30674) Fix some bug on migrations (go-gitea#30647) Fix checkbox field markup (go-gitea#30666) Avoid doubled border for the PR info segment (go-gitea#30663) Interpolate runs-on with variables when scheduling tasks (go-gitea#30640) Initial support for colorblindness-friendly themes (go-gitea#30625) Fix flash message for flex-container (go-gitea#30657) Perform Newest sort type correctly when sorting issues (go-gitea#30644) Fix project name wrapping, remove horizontal margin on header (go-gitea#30631) Add a db consistency check to remove runners that do not belong to a repository (go-gitea#30614) Fix wrong table name (go-gitea#30557) Fix compare api swagger (go-gitea#30648) [skip ci] Updated translations via Crowdin Fix queue test (go-gitea#30646) Enable jquery-related eslint rules that have no violations (go-gitea#30632) Enable more `revive` linter rules (go-gitea#30608) Remove obsolete CSS text classes (go-gitea#30576) Hide diff stats on empty PRs (go-gitea#30629) ...
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Apr 25, 2024
* giteaofficial/main: If a repository return no commitstatus, then still cache it but not query it from database (go-gitea#30700) [skip ci] Updated translations via Crowdin Fix view of readme file in the home code page. (go-gitea#30564) Add test for go-gitea#30674 (go-gitea#30679) Fix border-radius of header+segment boxes (go-gitea#30667)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very old bug with the bottom border-radiuses not being there and the
:hasselector now makes it possible to cleanly solve it. It affects all header+segment boxes, which there are many throughout the UI: