Add lint-go-gopls

[silverwind]

Uses gopls check <files> as a linter. Tested locally and brings up 149 errors currently for me. I don't think I want to fix them in this PR, but I would like at least to get this analysis running on CI.

List of errors:

modules/indexer/code/indexer.go:181:11: impossible condition: nil != nil
routers/private/hook_post_receive.go:120:15: tautological condition: nil == nil
services/auth/source/oauth2/providers.go:185:9: tautological condition: nil == nil
services/convert/issue.go:216:11: tautological condition: non-nil != nil
tests/integration/git_test.go:332:9: impossible condition: nil != nil
services/migrations/migrate.go:179:24-43: unused parameter: ctx
services/repository/transfer.go:288:48-69: unused parameter: doer
tests/integration/api_repo_tags_test.go:75:41-61: unused parameter: session
tests/integration/git_test.go:696:64-74: unused parameter: baseBranch
tests/integration/gpg_git_test.go:265:27-39: unused parameter: t
tests/integration/gpg_git_test.go:284:23-29: unused parameter: tmpDir
tests/integration/gpg_git_test.go:284:31-35: unused parameter: name
tests/integration/gpg_git_test.go:284:37-42: unused parameter: email

[silverwind]

The gopls check command currently does not set a proper exit code when there are errors, so we would likely have to analyze the output.

[silverwind]

Lint script added which performs error detection and error counting. It should now fail the CI like this and also be much less verbose with module downloads which it apparently does:

/Users/silverwind/git/gitea/modules/git/commit_info_nogogit.go:100:35-54: unused parameter: ctx [windows,amd64]
/Users/silverwind/git/gitea/modules/git/commit_info_nogogit.go:100:35-54: unused parameter: ctx
Found 149 'gopls check' errors
make: *** [Makefile:432: lint-go-gopls] Error 1

[silverwind]

Output and failure detection looks good now. I will add || true so we can merge it without fixing the errors.

[silverwind]

Will post an update later on the outstanding issues. I think we should only merge this after all issues have been fixed.

[silverwind]

49 errors left, #30735 will fix a few.

[silverwind]

It seems gopls has no support for //nolint currently, so we need to get more creative for technical debt like this one:

gitea/modules/graceful/manager_windows.go

Lines 44 to 45 in a21ca9b

	//lint:ignore SA1019 We use IsAnInteractiveSession because IsWindowsService has a different permissions profile
	isAnInteractiveSession, err := svc.IsAnInteractiveSession() //nolint:staticcheck

[silverwind]

It seems all deprecations that are warned here already have //nolint comments, so I'll just ignore any error with "is deprecated". Some of these should defintely be looked at though.

[silverwind]

This is ready now. I fixed all non-deprecation errors and one golang deprecation as well.

For reference, here are the remaining deprecated errors that are ignored:

routers/api/v1/repo/branch.go:237:16-33: opt.OldBranchName is deprecated: true Name of the old branch to create from
routers/api/v1/repo/branch.go:238:37-54: opt.OldBranchName is deprecated: true Name of the old branch to create from
routers/api/v1/repo/branch.go:239:54-71: opt.OldBranchName is deprecated: true Name of the old branch to create from
routers/api/v1/repo/branch.go:520:14-29: form.BranchName is deprecated: true
modules/markup/common/footnote.go:200:13-29: util.FindClosure is deprecated: This function can not handle newlines. Many elements can be existed over multiple lines(e.g. link labels). Use text.Reader.FindClosure.
modules/markup/common/footnote.go:290:13-29: util.FindClosure is deprecated: This function can not handle newlines. Many elements can be existed over multiple lines(e.g. link labels). Use text.Reader.FindClosure.
models/db/sql_postgres_with_schema.go:42:25-38: driver.Execer is deprecated: Drivers should implement [ExecerContext] instead.
models/db/sql_postgres_with_schema.go:67:11-20: stmt.Exec is deprecated: Drivers should implement StmtExecContext instead (or additionally).