Add API v3 routes for compitable with github #3076
Conversation
lunny
added
modifies/api
Codecov Report
@@ Coverage Diff @@
## master #3076 +/- ##
==========================================
- Coverage 33.46% 33.44% -0.02%
==========================================
Files 270 270
Lines 39595 39601 +6
==========================================
- Hits 13249 13245 -4
- Misses 24460 24466 +6
- Partials 1886 1890 +4
Continue to review full report at Codecov.
|
tboerger
added
the
lgtm/need 2
|
Can you add in the way that only one can be changed? |
|
@lafriks they point the same route function currently. So you will always change both. |
| }, context.APIContexter()) | ||
|
|
||
| m.Group("/v3", func() { | ||
| apiRoutes(m) |
There was a problem hiding this comment.
Some of these routes are not GitHub-compatible. They shouldn't be added to v3/ 😕
|
OK. I think we could add new route |
|
It would be best to also separate the route into sub-route to not have a "big file" like v1. |
| // RegisterRoutes registers all v1 APIs routes to web application. | ||
| // FIXME: custom form error response | ||
| func RegisterRoutes(m *macaron.Macaron) { | ||
| func apiRoutes(m *macaron.Macaron) { |
There was a problem hiding this comment.
I would add a ghCompat bool argument here, and if !ghCompat { ... } around any custom endpoints we have
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 months. Thank you for your contributions. |
|
Closing per above conversation, we can open a fresh PR that includes only routes compatible with GitHub v3 |
Copy all v1 routes to v3 currently.