Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify review UI #31062

Merged
merged 3 commits into from
May 27, 2024
Merged

Simplify review UI #31062

merged 3 commits into from
May 27, 2024

Conversation

delvh
Copy link
Member

@delvh delvh commented May 23, 2024

Instead of always displaying all available actions as buttons, merge them into a single dropdown menu, same as GitHub. That decreases visual overload and is more mobile-friendly, while not losing any functionality.

Screenshots

Before

grafik

After (unexpanded)

grafik

After (expanded)

grafik

@delvh
Simplify review UI
f329563 
Instead of always displaying all available actions as buttons,
merge them into a single dropdown menu, same as GitHub.
That decreases visual overload and is more mobile-friendly,
while not losing any functionality
@delvh delvh added type/enhancement An improvement of existing functionality topic/pr Issues related to pull requests topic/ui-interaction Change the process how users use Gitea instead of the visual appearance labels May 23, 2024
@delvh delvh self-assigned this May 23, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 23, 2024
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 23, 2024
@github-actions github-actions bot added the modifies/templates This PR modifies the template files label May 23, 2024
@lunny lunny added this to the 1.23.0 milestone May 24, 2024
@delvh
Copy link
Member Author

delvh commented May 24, 2024

Sidenote: I didn't even know we had an edit file button already.
For some reason, it was never shown…
All I did was move the code and add the item class and surrounding menu.

@lunny
Copy link
Member

lunny commented May 24, 2024 •
edited
Loading

Sidenote: I didn't even know we had an edit file button already. For some reason, it was never shown… All I did was move the code and add the item class and surrounding menu.

It's a new feature of v1.22, I would like to have delete file and rename file in v1.23

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 26, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 26, 2024
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 27, 2024
@lunny lunny enabled auto-merge (squash) May 27, 2024 07:55
@lunny lunny merged commit 072b029 into go-gitea:main May 27, 2024
26 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 27, 2024
@delvh delvh deleted the simplify-review-ui branch May 27, 2024 19:45
@metiftikci metiftikci mentioned this pull request May 28, 2024
Open
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Aug 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

Assignees

@delvh delvh

Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/templates This PR modifies the template files size/M Denotes a PR that changes 30-99 lines, ignoring generated files. topic/pr Issues related to pull requests topic/ui-interaction Change the process how users use Gitea instead of the visual appearance type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.
4 participants
@delvh @lunny @wxiaoguang @GiteaBot