Fix line number width in code preview #31307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/XS
silverwind
added
backport/v1.22
delvh
approved these changes
Jun 10, 2024
GiteaBot
added
lgtm/need 1
wxiaoguang
approved these changes
Jun 11, 2024
GiteaBot
added
lgtm/done
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Jun 11, 2024
Line numbers were using some hacky CSS `width: 1%` that did nothing to the code rendering as far as I can tell but broken the inline preview in markup when line numbers are greater than 2 digits. Also I removed one duplicate `font-family` rule (it is set below in the `.lines-num, .lines-code` selector.
wxiaoguang
pushed a commit
that referenced
this pull request
Jun 11, 2024
Backport #31307 by silverwind Line numbers were using some hacky CSS `width: 1%` that did nothing to the code rendering as far as I can tell but broken the inline preview in markup when line numbers are greater than 2 digits. Also I removed one duplicate `font-family` rule (it is set below in the `.lines-num, .lines-code` selector. Co-authored-by: silverwind <[email protected]>
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Jun 11, 2024
* giteaofficial/main: Fix line number width in code preview (go-gitea#31307) Delete legacy cookie before setting new cookie (go-gitea#31306) [skip ci] Updated translations via Crowdin Use `querySelector` over alternative DOM methods (go-gitea#31280) Remove jQuery `.text()` (go-gitea#30506) [skip ci] Updated translations via Crowdin Remove sub-path from container registry realm (go-gitea#31293) Fix some URLs whose sub-path is missing (go-gitea#31289)
|
This change doesn't seem right.
|
|
Odd, I didn't notice that. Does it only affect plaintext files? |
|
It affects more, the column width seems kind of random when I click various files. |
silverwind
added a commit
that referenced
this pull request
Jun 12, 2024
Fixes regression #31307 (comment) Table CSS is weird. A `auto` value does not work and causes the regression while any pixel value causes another regression in diff where the code lines do not stretch. Partially revert that PR and clean up some related too-deep CSS selectors. <img width="109" alt="Screenshot 2024-06-12 at 15 07 22" src="https://github.com/go-gitea/gitea/assets/115237/756c5dea-44b8-49f9-8a08-acef68075f62"> <img width="119" alt="Screenshot 2024-06-12 at 15 07 43" src="https://github.com/go-gitea/gitea/assets/115237/28ae1adc-118e-4016-8d09-033b9f1c9a6f"> <img width="151" alt="Screenshot 2024-06-12 at 15 07 07" src="https://github.com/go-gitea/gitea/assets/115237/08db7ed9-de4e-405e-874d-c7ebe3082557"> <img width="141" alt="Screenshot 2024-06-12 at 15 07 14" src="https://github.com/go-gitea/gitea/assets/115237/c4a5492b-1bf1-4773-bc8d-64eb36d823f9">
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Jun 12, 2024
Fixes regression go-gitea#31307 (comment) Table CSS is weird. A `auto` value does not work and causes the regression while any pixel value causes another regression in diff where the code lines do not stretch. Partially revert that PR and clean up some related too-deep CSS selectors. <img width="109" alt="Screenshot 2024-06-12 at 15 07 22" src="https://github.com/go-gitea/gitea/assets/115237/756c5dea-44b8-49f9-8a08-acef68075f62"> <img width="119" alt="Screenshot 2024-06-12 at 15 07 43" src="https://github.com/go-gitea/gitea/assets/115237/28ae1adc-118e-4016-8d09-033b9f1c9a6f"> <img width="151" alt="Screenshot 2024-06-12 at 15 07 07" src="https://github.com/go-gitea/gitea/assets/115237/08db7ed9-de4e-405e-874d-c7ebe3082557"> <img width="141" alt="Screenshot 2024-06-12 at 15 07 14" src="https://github.com/go-gitea/gitea/assets/115237/c4a5492b-1bf1-4773-bc8d-64eb36d823f9">
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Line numbers were using some hacky CSS
width: 1%that did nothing to the code rendering as far as I can tell but broken the inline preview in markup when line numbers are greater than 2 digits. Also I removed one duplicatefont-familyrule (it is set below in the.lines-num, .lines-codeselector.Before:
After: