Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue Templates: add option to have dropdown printed list #31577

Merged
merged 6 commits into from
Jul 14, 2024
Merged

Issue Templates: add option to have dropdown printed list #31577

merged 6 commits into from
Jul 14, 2024

Conversation

6543
Copy link
Member

@6543 6543 commented Jul 5, 2024 •
edited
Loading

Issue template dropdown can have many entries, and it could be better to have them rendered as list later on if multi-select is enabled.

so this adds an option to the issue template engine to do so.

DOCS: https://gitea.com/gitea/docs/pulls/19

demo:

name: Name
title: Title
about: About
labels: ["label1", "label2"]
ref: Ref
body:
  - type: dropdown
    id: id6
    attributes:
      label: Label of dropdown (list)
      description: Description of dropdown
      multiple: true
      list: true
      options:
        - Option 1 of dropdown
        - Option 2 of dropdown
        - Option 3 of dropdown
        - Option 4 of dropdown
        - Option 5 of dropdown
        - Option 6 of dropdown
        - Option 7 of dropdown
        - Option 8 of dropdown
        - Option 9 of dropdown

image
image

Sponsored by Kithara Software GmbH

@6543 6543 added the type/enhancement An improvement of existing functionality label Jul 5, 2024
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 5, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 5, 2024
@github-actions github-actions bot added modifies/go Pull requests that update Go code modifies/docs labels Jul 5, 2024
@lunny
Copy link
Member

lunny commented Jul 6, 2024

Please send docs update to https://gitea.com/gitea/docs

@lunny lunny added this to the 1.23.0 milestone Jul 11, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 11, 2024
@KN4CK3R
Copy link
Member

KN4CK3R commented Jul 14, 2024

Does Github support this?

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 14, 2024
@6543
Copy link
Member Author

6543 commented Jul 14, 2024

Does Github support this?

no, but they should :D

(we already support all features github offers if I'm not mistaken)

@6543
Copy link
Member Author

6543 commented Jul 14, 2024

https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/syntax-for-githubs-form-schema#attributes-for-dropdown looks like we are missing the 'default' option ...

@6543 6543 merged commit 1064e81 into go-gitea:main Jul 14, 2024
26 checks passed
@6543 6543 deleted the issue_template/flat-out-multi-select branch July 14, 2024 14:38
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jul 16, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
bf21df7 
* giteaofficial/main:
  Code editor theme enhancements (go-gitea#31629)
  Add option to change mail from user display name (go-gitea#31528)
  Upgrade xorm to v1.3.9 and improve some migrations Sync (go-gitea#29899)
  Issue Templates: add option to have dropdown printed list (go-gitea#31577)
  Fix update flake (go-gitea#31626)
silverwind added a commit to techknowlogick/gitea that referenced this pull request Jul 23, 2024
@silverwind
Merge remote-tracking branch 'origin/main' into nolyfill
48fdc78 
* origin/main: (59 commits)
  fix OIDC introspection authentication (go-gitea#31632)
  Enable direnv (go-gitea#31672)
  [skip ci] Updated translations via Crowdin
  [skip ci] Updated translations via Crowdin
  fix redis dep (go-gitea#31662)
  add skip secondary authorization option for public oauth2 clients (go-gitea#31454)
  Fix a branch divergence cache bug (go-gitea#31659)
  [skip ci] Updated translations via Crowdin
  Remove unneccessary uses of `word-break: break-all` (go-gitea#31637)
  [skip ci] Updated translations via Crowdin
  Allow searching issues by ID (go-gitea#31479)
  allow synchronizing user status from OAuth2 login providers (go-gitea#31572)
  Enable `no-jquery/no-class-state` (go-gitea#31639)
  Added default sorting milestones by name (go-gitea#27084)
  Code editor theme enhancements (go-gitea#31629)
  Add option to change mail from user display name (go-gitea#31528)
  Upgrade xorm to v1.3.9 and improve some migrations Sync (go-gitea#29899)
  Issue Templates: add option to have dropdown printed list (go-gitea#31577)
  Fix update flake (go-gitea#31626)
  [skip ci] Updated translations via Crowdin
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunny lunny lunny approved these changes

@KN4CK3R KN4CK3R KN4CK3R approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.
4 participants
@6543 @lunny @KN4CK3R @GiteaBot